Sécurité: correction des vulnérabilités de redirection ouverte#5512
Merged
Conversation
In cases of unsafe provided values, the behavior will be sligthly different.
xavfernandez
commented
Jan 31, 2025
Comment on lines
109
to
110
| next_url = request.GET.get("next_url") | ||
| if next_url and not url_has_allowed_host_and_scheme(next_url, settings.ALLOWED_HOSTS, request.is_secure()): |
Contributor
Author
There was a problem hiding this comment.
J'ai hésité à faire un:
Suggested change
| next_url = request.GET.get("next_url") | |
| if next_url and not url_has_allowed_host_and_scheme(next_url, settings.ALLOWED_HOSTS, request.is_secure()): | |
| next_url = get_safe_url(request, "next_url") | |
| if request.GET.get("next_url") and not next_url: |
Member
There was a problem hiding this comment.
Je trouve que c’est moins clair.
francoisfreitag
approved these changes
Jan 31, 2025
Member
francoisfreitag
left a comment
francoisfreitag
left a comment
There was a problem hiding this comment.
J’ai greppé pour redirect|HttpResponseRedirect, ainsi que request.(GET|POST) sans trouver d’autres cas. 🙏
leo-naeka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour que nos utilisateurs ne se fassent pas piéger.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran