Skip to content

GPS: Créer et mettre à jour les groupes de suivi#5515

Merged
tonial merged 2 commits into
masterfrom
alaurent/gps_sync_groups_backlog
Feb 3, 2025
Merged

GPS: Créer et mettre à jour les groupes de suivi#5515
tonial merged 2 commits into
masterfrom
alaurent/gps_sync_groups_backlog

Conversation

@tonial

@tonial tonial commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

🤔 Pourquoi ?

Ajout d'une commande pour créer les groupes de suivi qui n'ont pas été créés depuis la commande initiale de création
Mise à jour de la date de dernier contact pour tous les groupes de suivi où l'on trouve l'information.

Une prochaine PR ajoutera une commande pour remplir ce champ artificiellement pour les relations restantes (en prenant la valeur de created_at) et passera la colonne en nullable=False

NB: La management command prends 12 minutes en local.

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?
  • Ajouter l'étiquette « Bug » ?

🏝️ Comment tester ?

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@tonial tonial added the modifié Modifié dans le changelog. label Jan 31, 2025
@tonial tonial requested a review from xavfernandez January 31, 2025 21:44
@tonial tonial self-assigned this Jan 31, 2025
We don't need stderr and stdout since the commands use loggers
Comment thread itou/gps/management/commands/sync_follow_up_groups_and_members.py Outdated

@francoisfreitag francoisfreitag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Très chouette mutualisation, et le code mutualisé est très facile à suivre 💯

Comment thread itou/gps/management/commands/sync_follow_up_groups_and_members.py Outdated
Comment thread itou/gps/management/commands/sync_follow_up_groups_and_members.py Outdated
Comment thread itou/gps/management/commands/sync_follow_up_groups_and_members.py Outdated
Comment thread itou/gps/management/commands/sync_follow_up_groups_and_members.py Outdated
Comment thread itou/gps/management/commands/sync_follow_up_groups_and_members.py Outdated
Comment thread tests/gps/test_management_commands.py Outdated
Comment thread tests/gps/test_management_commands.py Outdated
Comment thread tests/gps/test_management_commands.py Outdated
@tonial tonial force-pushed the alaurent/gps_sync_groups_backlog branch 4 times, most recently from 17d3a56 to 58759d4 Compare February 3, 2025 11:18

@francoisfreitag francoisfreitag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳

Comment thread itou/gps/management/commands/sync_follow_up_groups_and_members.py Outdated
One command to rule them all
@tonial tonial force-pushed the alaurent/gps_sync_groups_backlog branch from 58759d4 to ea7f953 Compare February 3, 2025 13:09
@tonial tonial enabled auto-merge February 3, 2025 13:10
@tonial tonial added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit e6a9c2f Feb 3, 2025
@tonial tonial deleted the alaurent/gps_sync_groups_backlog branch February 3, 2025 13:28
@sentry

sentry Bot commented Feb 3, 2025

Copy link
Copy Markdown

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ User.MultipleObjectsReturned: get() returned more than one User -- it returned 11! itou.gps.management.commands.sync_follow_up_gro... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modifié Modifié dans le changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants