Skip to content

GPS: Rendre la date de dernier contact obligatoire#5516

Merged
tonial merged 2 commits into
masterfrom
alaurent/gps_last_contact
Feb 3, 2025
Merged

GPS: Rendre la date de dernier contact obligatoire#5516
tonial merged 2 commits into
masterfrom
alaurent/gps_last_contact

Conversation

@tonial
Copy link
Copy Markdown
Contributor

@tonial tonial commented Feb 1, 2025

🤔 Pourquoi ?

A passer après #5515
Cela nous permettra de trier sur last_contact_at dans la liste des groupes de suivi (à venir)

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?
  • Ajouter l'étiquette « Bug » ?

🏝️ Comment tester ?

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@tonial tonial added the modifié Modifié dans le changelog. label Feb 1, 2025
@tonial tonial self-assigned this Feb 1, 2025
@tonial tonial force-pushed the alaurent/gps_last_contact branch from a2301d3 to 35d00a3 Compare February 1, 2025 06:54
@tonial tonial changed the base branch from master to alaurent/gps_sync_groups_backlog February 1, 2025 06:54
@tonial tonial force-pushed the alaurent/gps_last_contact branch 2 times, most recently from 5c6dae1 to 52625d5 Compare February 1, 2025 19:05
@tonial tonial changed the base branch from alaurent/gps_sync_groups_backlog to alaurent/gps_admin February 1, 2025 19:05
xavfernandez
xavfernandez approved these changes Feb 3, 2025
View reviewed changes
Comment thread itou/gps/migrations/0007_fill_membership_last_contact_at.py
@tonial tonial force-pushed the alaurent/gps_last_contact branch from 52625d5 to 4ca1756 Compare February 3, 2025 10:00
@tonial tonial force-pushed the alaurent/gps_admin branch from 7b40c9f to 46136d4 Compare February 3, 2025 10:00
@tonial tonial force-pushed the alaurent/gps_last_contact branch from 4ca1756 to 1b037b8 Compare February 3, 2025 11:07
@tonial tonial force-pushed the alaurent/gps_admin branch from 46136d4 to 1d45c9c Compare February 3, 2025 11:07
@tonial tonial force-pushed the alaurent/gps_last_contact branch from 1b037b8 to abe9241 Compare February 3, 2025 11:19
@tonial tonial force-pushed the alaurent/gps_admin branch 3 times, most recently from 66341e5 to 89f2d48 Compare February 3, 2025 13:30
@tonial tonial force-pushed the alaurent/gps_last_contact branch 2 times, most recently from 45546e4 to 3813ada Compare February 3, 2025 13:34
@tonial tonial force-pushed the alaurent/gps_admin branch from 89f2d48 to c88d7e9 Compare February 3, 2025 13:34
Base automatically changed from alaurent/gps_admin to master February 3, 2025 13:57
@tonial tonial force-pushed the alaurent/gps_last_contact branch from 3813ada to 567e94a Compare February 3, 2025 14:10
@tonial tonial enabled auto-merge February 3, 2025 14:11
@tonial tonial added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit ba903f4 Feb 3, 2025
@tonial tonial deleted the alaurent/gps_last_contact branch February 3, 2025 14:28
@francoisfreitag
Copy link
Copy Markdown
Member

francoisfreitag commented Feb 3, 2025

Je pense que cette PR a cassé les fixtures:

$ make resetdb
django.db.utils.IntegrityError: null value in column "last_contact_at" of relation "gps_followupgroupmembership" violates not-null constraint
DETAIL:  Failing row contains (1, t, t, 2024-06-12 00:00:00+00, null, 2025-02-03 16:32:25.328704+00, 1, 1, 4, f, null).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

@EwenKorr EwenKorr Awaiting requested review from EwenKorr

Assignees

@tonial tonial

Labels

modifié Modifié dans le changelog.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tonial @francoisfreitag @xavfernandez @EwenKorr