Skip to content

Tech : Ajouter des méthodes pour tracer les types d'enterprise SIAEs#5535

Merged
calummackervoy merged 1 commit into
masterfrom
calum/rename-variable
Feb 27, 2025
Merged

Tech : Ajouter des méthodes pour tracer les types d'enterprise SIAEs#5535
calummackervoy merged 1 commit into
masterfrom
calum/rename-variable

Conversation

@calummackervoy

Copy link
Copy Markdown
Contributor

🤔 Pourquoi ?

#5498 (comment)

Propostion de refacteur pour améliorer la lisibilité, inclure un test qui protège l'ajout des nouveaux valeurs sur CompanyKind

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?
  • Ajouter l'étiquette « Bug » ?

Comment thread itou/companies/enums.py
Comment thread tests/companies/test_enums.py Outdated
Comment thread tests/companies/test_enums.py Outdated
Comment thread tests/companies/test_enums.py Outdated
Comment thread tests/companies/test_enums.py Outdated
Improve readability. Also includes a test designed to require any new company kinds are explicitly defined as SIAE or not, to prevent bugs
@calummackervoy calummackervoy added this pull request to the merge queue Feb 27, 2025
Merged via the queue into master with commit 2ca7976 Feb 27, 2025
@calummackervoy calummackervoy deleted the calum/rename-variable branch February 27, 2025 16:38
@francoisfreitag francoisfreitag changed the title Tech: Ajouter des méthodes pour tracer les types d'enterprise SIAEs Tech : Ajouter des méthodes pour tracer les types d'enterprise SIAEs Feb 27, 2025
@vincentporte vincentporte added ajouté Ajouté dans le changelog. tech and removed ajouté Ajouté dans le changelog. labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants