Prescripteur : amélioration de la modale confirmant qu'un candidat existe déjà avec ce NIR ou cet email [GEN-2198]#5537
Merged
Conversation
EwenKorr
force-pushed
the
ewen/modale-existing-jobseeker
branch
2 times, most recently
from
16b68b8 to
f631b74
Compare
EwenKorr
commented
Feb 6, 2025
EwenKorr
force-pushed
the
ewen/modale-existing-jobseeker
branch
from
f631b74 to
6520bef
Compare
EwenKorr
added
the
1-recette-jetable
EwenKorr
changed the title
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
hellodeloo
approved these changes
Feb 6, 2025
hellodeloo
left a comment
hellodeloo
left a comment
Contributor
There was a problem hiding this comment.
Niveau html/css/theme, c'es tout bon 👍
leo-naeka
reviewed
Feb 12, 2025
leo-naeka
left a comment
leo-naeka
left a comment
Contributor
There was a problem hiding this comment.
Je livre déjà ces commentaires, dans l'attente de la reprise avec une méthode unique pour récupérer la liste de ses candidats ;)
EwenKorr
force-pushed
the
ewen/modale-existing-jobseeker
branch
2 times, most recently
from
f539af9 to
e85f492
Compare
EwenKorr
force-pushed
the
ewen/modale-existing-jobseeker
branch
from
e85f492 to
e3ecadd
Compare
EwenKorr
force-pushed
the
ewen/modale-existing-jobseeker
branch
4 times, most recently
from
06b5470 to
56c71ac
Compare
Contributor
There was a problem hiding this comment.
J'imagine que celui-ci tu peux le supprimer ?
This is used to get a list of a user's job seeker ids (ie. job seekers created by the user, or by the current organization, or for whom the user has applied). This logic was located in a view in job_seekers_views but is better in the ItouUserManager, in order to be used as `User.objects.linked_job_seeker_ids(user, organization)`
Information other that the public_id will be used.
In CheckNIR or SearchByEmail, we display a modal when a job seeker matches the NIR or email. There are multiple cases, and the wording should reflect them: - in the context of a job application - GPS - standalone creation, when a job seeker isn't in the user's list - standalone creation, when a job seeker is already in the user's list
EwenKorr
force-pushed
the
ewen/modale-existing-jobseeker
branch
from
56c71ac to
d954b64
Compare
xavfernandez
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Lorsqu'on insère un NIR ou une adresse mail au début du parcours de création de compte candidat, une modale apparaît lorsqu'un candidat correspond à ce NIR ou cette adresse email.
Dans le cas d'une création de compte candidat sans candidature, il a plusieurs sous-cas :
La présente PR ajoute ces deux cas à cette modale.
🏝️ Comment tester ?
💻 Captures d'écran