Repository navigation
Performance: amélioration de la page nouveautés - #5554
Merged
xavfernandez merged 2 commits intoFeb 7, 2025
Merged
Conversation
2 tasks
xavfernandez
force-pushed
the
xfernandez/denormalize_image_dimensions_part2
branch
from
February 6, 2025 10:11
bd12728 to
710bf2f
Compare
francoisfreitag
approved these changes
Feb 6, 2025
It is too costly to check all displayed files in S3
xavfernandez
force-pushed
the
xfernandez/denormalize_image_dimensions_part2
branch
from
February 6, 2025 22:10
30bd9b1 to
3e38465
Compare
xavfernandez
added this pull request to the merge queue
Feb 7, 2025
xavfernandez
deleted the
xfernandez/denormalize_image_dimensions_part2
branch
February 7, 2025 08:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Suite de #5553
Et c'est toujours pour éviter de devoir accéder à S3 pour connaître la taille des images et vérifier que le fichier existe.
Et ainsi éviter https://inclusion.sentry.io/insights/backend/trace/3bbb8aac461f4289b2eaccfe0ff6a140/
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran