RGPD: Ne pas mettre les adresses géolocalisées par les management commands dans la sortie standard - #5583
Merged
Merged
Conversation
tonial
force-pushed
the
alaurent/codeql
branch
from
February 10, 2025 14:43
8ba6b27 to
c1bb2c4
Compare
xavfernandez
approved these changes
Feb 10, 2025
xavfernandez
left a comment
Contributor
There was a problem hiding this comment.
Après il faut avoir en tête que ces deux commandes ne sont jamais lancées par des crons et leurs sorties n’atterrissent donc jamais dans les logs.
Sinon, il faudrait remplacer quelques self.stdout.write et print par des logger.info 😛
francoisfreitag
approved these changes
Feb 10, 2025
But keep the possibility for local tests
Contributor
Author
|
Comme il est évoqué dans les commandes qu'on pourrait le faire régulièrement, j'ai préféré anticiper un potentiel futur problème |
tonial
force-pushed
the
alaurent/codeql
branch
from
February 10, 2025 15:40
c1bb2c4 to
55dbbae
Compare
tonial
added this pull request to the merge queue
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Suite à cette remontée: https://github.com/gip-inclusion/les-emplois/security/code-scanning/129
Seules ces 2 commandes utilise ce code, et effectivement c'est mieux que ça ne finisse pas en print dans les données collectées par clever.
Je le rend facultatif pour permettre d'afficher les données en local lors de tests manuels (qui on a priori permis à victor de faire ces stats à l'époque).
Je me demande si on ne peut pas désormais supprimer update_companies_coords maintenant que c'est fait automatiquement à chaque modification dans l'admin 🤔
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran