Certification AAH#5584
Merged
Merged
Conversation
celine-m-s
force-pushed
the
celinems/certify-aah
branch
from
3ee32d8 to
5bfa04f
Compare
2 tasks
francoisfreitag
force-pushed
the
celinems/certify-aah
branch
from
5bfa04f to
74757ea
Compare
Member
|
C’est grossièrement rebased, il faudra faire une passe dessus lundi. |
celine-m-s
force-pushed
the
celinems/certify-aah
branch
3 times, most recently
from
f7f8e52 to
b56be6f
Compare
celine-m-s
force-pushed
the
celinems/certify-aah
branch
from
b56be6f to
e669600
Compare
francoisfreitag
approved these changes
Feb 18, 2025
celine-m-s
force-pushed
the
celinems/certify-aah
branch
from
e669600 to
bab667c
Compare
celine-m-s
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
celine-m-s
force-pushed
the
celinems/certify-aah
branch
from
bab667c to
869cef9
Compare
celine-m-s
removed
the
1-recette-jetable
francoisfreitag
approved these changes
Feb 19, 2025
francoisfreitag
left a comment
francoisfreitag
left a comment
Member
There was a problem hiding this comment.
LGTM!
Les messages de commits mériteraient un petit retravail pour donner des précisions:
- Pourquoi avoir mutualisé les endpoints AAH avec RSA
- Keep same params order as everywhere else -> Update TestCertifyCriteria::test_retry_task_rate_limits factory call params order (l’objectif étant qu’un
git log --onelinedonne une idée de ce que le commit change) - API particulier: Test when a criterion is not certified.
celine-m-s
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
celine-m-s
force-pushed
the
celinems/certify-aah
branch
from
869cef9 to
55548fd
Compare
Contributor
Author
|
@francoisfreitag C'est fait. 🎁 🍫 |
celine-m-s
added
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
- Add AAH to certifiable criteria. - Add functional tests to ensure diagnosis and application paths work with this new criteria. - API client: add a new endpoint - test_api_particulier.py: I didn't test HTTP error codes with this new endpoint because JSON responses are the same for AAH and RSA endpoints and are mocked anyway. Instead, let's consider testing error responses only for the RSA endpoint is good enough.
…params order Keep same params order as everywhere else
celine-m-s
force-pushed
the
celinems/certify-aah
branch
from
55548fd to
727c8d9
Compare
|
Bonjour, je suis développeur php symfony et react / vue js si je peux aider, je suis diplômé d'un titre RNCP de niv 5 :) Aussi, si ce commentaire dérange vous êtes libre de le supprimer. Au plaisir |
Contributor
Author
|
Bonjour @belbeche , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Utiliser l'API Particulier pour certifier le critère AAH (Allocation Adulte Handicapé).
🍰 Comment ?
Ajout du critère AAH à la liste des critères certifiables.
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran