Skip to content

Permettre de réactiver un member d'une organisation depuis l'admin - #5589

Merged
tonial merged 1 commit into
masterfrom
alaurent/admin_memberships
Feb 11, 2025
Merged

Permettre de réactiver un member d'une organisation depuis l'admin#5589
tonial merged 1 commit into
masterfrom
alaurent/admin_memberships

Conversation

@tonial

@tonial tonial commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

🤔 Pourquoi ?

Depuis #5430 il n'est plus possible de réactiver un object membership (ce qui se faisant en supprimant/re-créant l'existant 😱 )

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?
  • Ajouter l'étiquette « Bug » ?

🏝️ Comment tester ?

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@tonial tonial added the modifié Modifié dans le changelog. label Feb 11, 2025
@tonial tonial self-assigned this Feb 11, 2025

@xavfernandez xavfernandez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 avec un petit test ?
8d1b65f38b68ac269f870b388b4c0c05_w200

@tonial

tonial commented Feb 11, 2025

Copy link
Copy Markdown
Contributor Author

cc slack : Les tests arrivent soon :trade-mark:

@tonial
tonial force-pushed the alaurent/admin_memberships branch from 873bfcd to 1d5266e Compare February 11, 2025 10:44

@francoisfreitag francoisfreitag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus qu’à copier ces changements dans les test_delete_admin de companies et prescribers. J’ai pour tâche de les mutualiser sous peu.

@tonial
tonial force-pushed the alaurent/admin_memberships branch 3 times, most recently from 6962e18 to 6836fed Compare February 11, 2025 11:05
Comment thread tests/companies/test_admin.py Outdated
We need to be able to enable memberships
@tonial
tonial force-pushed the alaurent/admin_memberships branch from 6836fed to 00882bd Compare February 11, 2025 11:38
@tonial
tonial added this pull request to the merge queue Feb 11, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025
@tonial
tonial added this pull request to the merge queue Feb 11, 2025
Merged via the queue into master with commit b9a6b7a Feb 11, 2025
@tonial
tonial deleted the alaurent/admin_memberships branch February 11, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modifié Modifié dans le changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants