A11Y: Ajout des attibuts aria sur tous les <i> remixicon#5601
Merged
hellodeloo merged 1 commit intomasterfrom Feb 12, 2025
Merged
A11Y: Ajout des attibuts aria sur tous les <i> remixicon#5601hellodeloo merged 1 commit intomasterfrom
hellodeloo merged 1 commit intomasterfrom
Conversation
hellodeloo
changed the title
hellodeloo
changed the title
xavfernandez
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour corriger les erreurs d'accessibilité potentielles
🍰 Comment ?
En harmonisant les règles. A savoir :
Comme les
<i class="ri-*></i>ne contiennent généralement pas de contenu texte et ne sont là que comme une aide visuelle, elles doivent être ignorées par les lecteurs d'écran. Pour cela, le plus simple est d'ajouter unaria-hidden="true"sur ces<i class="ri-*></i>Cependant, parfois, les
<i class="ri-*></i>se trouvent dans un<parent>qui ne contient ni texte, ni aria-label pour informer de son rôle/utilité/. Dans ce cas, il ne faut pas mettre d'aria-hidden=true"sur l'icone<i class="ri-*></i>mais unaria-label="xxx".