Skip to content

Fiches salarié : Mise en place d’une page d’aide pour les employeurs [GEN-2218]#5616

Merged
tonial merged 2 commits into
masterfrom
alaurent/employee_records_wording
Feb 24, 2025
Merged

Fiches salarié : Mise en place d’une page d’aide pour les employeurs [GEN-2218]#5616
tonial merged 2 commits into
masterfrom
alaurent/employee_records_wording

Conversation

@tonial

@tonial tonial commented Feb 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤔 Pourquoi ?

Pour permettre aux employeurs de mieux comprendre leur situation et éviter des contacts au support

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?
  • Ajouter l'étiquette « Bug » ?

🏝️ Comment tester ?

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@tonial tonial added the modifié Modifié dans le changelog. label Feb 14, 2025
@tonial tonial self-assigned this Feb 14, 2025
@tonial tonial force-pushed the alaurent/employee_records_wording branch from e7441ae to 2e8d04a Compare February 14, 2025 14:29
@tonial tonial added the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Feb 14, 2025
@github-actions

github-actions Bot commented Feb 14, 2025

Copy link
Copy Markdown

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@tonial tonial force-pushed the alaurent/employee_records_wording branch from 2e8d04a to 0f95069 Compare February 14, 2025 14:40
xavfernandez
xavfernandez reviewed Feb 14, 2025
View reviewed changes
Comment thread itou/templates/employee_record/missing_employee.html Outdated
Comment thread itou/templates/employee_record/missing_employee.html Outdated
Comment thread itou/www/employee_record_views/enums.py Outdated
Comment thread itou/www/employee_record_views/views.py
@tonial tonial force-pushed the alaurent/employee_records_wording branch 8 times, most recently from bff4c59 to 6d0e786 Compare February 18, 2025 08:26
rsebille
rsebille reviewed Feb 18, 2025
View reviewed changes
Comment thread itou/templates/employee_record/add.html Outdated
Comment thread itou/templates/employee_record/missing_employee.html Outdated
Comment thread itou/www/employee_record_views/views.py
Comment thread itou/www/employee_record_views/views.py Outdated
Comment thread itou/www/employee_record_views/views.py Outdated
Comment thread itou/www/employee_record_views/views.py Outdated
Comment thread itou/www/employee_record_views/views.py Outdated
Comment thread itou/www/employee_record_views/views.py Outdated
@tonial tonial requested a review from rsebille February 18, 2025 14:01
@tonial tonial force-pushed the alaurent/employee_records_wording branch 3 times, most recently from c24e510 to 43393f6 Compare February 18, 2025 14:17
xavfernandez
xavfernandez reviewed Feb 18, 2025
View reviewed changes
Comment thread itou/templates/employee_record/missing_employee.html Outdated
Comment thread itou/templates/employee_record/missing_employee.html
@tonial tonial force-pushed the alaurent/employee_records_wording branch 3 times, most recently from 2b5f28a to af235c1 Compare February 20, 2025 05:34
@tonial tonial force-pushed the alaurent/employee_records_wording branch from af235c1 to 799f618 Compare February 24, 2025 05:58
rsebille
rsebille approved these changes Feb 24, 2025
View reviewed changes

@rsebille rsebille left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tonial tonial added this pull request to the merge queue Feb 24, 2025
Merged via the queue into master with commit 11b933f Feb 24, 2025
@tonial tonial deleted the alaurent/employee_records_wording branch February 24, 2025 09:41
@sentry

sentry Bot commented Feb 25, 2025

Copy link
Copy Markdown

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: '>' not supported between instances of 'NoneType' and 'datetime.date' /employee_record/missing View Issue

Did you find this useful? React with a 👍 or 👎

@francoisfreitag francoisfreitag changed the title Fiches salarié: Mise en place d'une page d'aide pour les employeurs [GEN-2218] Fiches salarié : Mise en place d’une page d’aide pour les employeurs [GEN-2218] Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xavfernandez xavfernandez xavfernandez left review comments
+1 more reviewer
@rsebille rsebille rsebille approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tonial tonial

Labels

1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC modifié Modifié dans le changelog.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tonial @xavfernandez @rsebille