Profil salarié : afficher l’encart Immersion Facilitée de la page de tous les salariés [GEN-355]#5638
Merged
Merged
Conversation
631bf99 to
297aef9
Compare
297aef9 to
49c524b
Compare
| context["link_immersion_facile"] = None | ||
|
|
||
| if approval and approval.remainder.days < 90 and self.request.user.is_employer: | ||
| if approval and self.request.user.is_employer: |
Contributor
There was a problem hiding this comment.
Pourquoi conditionner l'affichage de ce bandeau à l'existence d'un PASS ?
Ensuite, le self.request.user.is_employer est toujours True (en tout cas on l'espère 😅 ) vu qu'on fait un self.siae = get_current_company_or_404(request) dans le setup.
Contributor
Author
There was a problem hiding this comment.
Bien vu ! Nouvelle revue stp. 🙏
49c524b to
dbfbefc
Compare
dbfbefc to
05e1a0c
Compare
xavfernandez
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
La mise en place de l’encart IF sur la page salarié ne semble pas avoir d’impact sur les sorties positives. Nombre de visites très faible. 243 depuis début octobre. Taux de conversion à 0,6% sur 2024. ( 1 demande d’immersion au total sur 2024)
🍰 Comment ?
On l’affiche sur toutes les pages salarié et pas seulement celles dont les PASS arrivent à expiration dans moins de 90 jours.
Techniquement on passe de 2 à 3 cas, voir plus bas.
💻 Captures d'écran
Cas 1 inchangé : pass expiré
Cas 2 inchangé : pass expirant dans moins de 3 mois
Cas 3 nouveau : pass expirant dans plus de 3 mois ou pas de pass => wording validé par Marion ✅