Skip to content

UX/UI: Optimisations UX/UI/A11Y des formulaires d'inscription - #5643

Merged
hellodeloo merged 2 commits into
masterfrom
deloo/ux-improvement-of-signup-forms
Mar 6, 2025
Merged

UX/UI: Optimisations UX/UI/A11Y des formulaires d'inscription#5643
hellodeloo merged 2 commits into
masterfrom
deloo/ux-improvement-of-signup-forms

Conversation

@hellodeloo

@hellodeloo hellodeloo commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

🤔 Pourquoi ?

Upgrade de bonnes pratiques UX et A11Y

🍰 Comment ?

Modifications des paramètres "help_text" et "placholder" de certains champs de formulaire. Mais pourquoi faire ?

Ajout de l'attribut "autocomplete" pour certains champs dont le contenu attendu ne prête pas à confusion
(ex: le champ "nom" d'un candidat peut posséder un autocomplete="family-name" quand c'est le candidat qui s'enregistre, pas quand c'est une structure qui l'enregistre)

Au passage, quelques corrections et harmonisations UI

💻 Captures d'écran

Candidat avant
capture 2025-02-18 à 17 28 57
Screenshot 2025-02-18 at 17-29-50 Demandeur d'emploi - Inscription - Les emplois de l'inclusion

Candidat apres
Screenshot 2025-02-18 at 15-53-20 Demandeur d'emploi - Inscription - Les emplois de l'inclusion
Screenshot 2025-02-18 at 15-53-33 Demandeur d'emploi - Inscription - Les emplois de l'inclusion


Employeur inclusif apres
Screenshot 2025-02-18 at 15-52-29 Employeur inclusif - Inscription - Les emplois de l'inclusion

@hellodeloo hellodeloo added the modifié Modifié dans le changelog. label Feb 18, 2025
@hellodeloo hellodeloo self-assigned this Feb 18, 2025
@notion-workspace

Copy link
Copy Markdown

@hellodeloo hellodeloo changed the title Deloo/ux improvement of signup forms UX/UI: improvement of signup forms Feb 18, 2025
@hellodeloo hellodeloo changed the title UX/UI: improvement of signup forms UX/UI: Optimisations UX/UI/A11Y des formulaires d'inscription Feb 18, 2025
@hellodeloo
hellodeloo force-pushed the deloo/ux-improvement-of-signup-forms branch from 1150eca to 780030f Compare February 18, 2025 16:39
@hellodeloo hellodeloo added the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Feb 18, 2025
@github-actions

Copy link
Copy Markdown

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@hellodeloo
hellodeloo force-pushed the deloo/ux-improvement-of-signup-forms branch from 780030f to 7e90e23 Compare March 3, 2025 15:08

@vincentporte vincentporte left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beau travail 🔥 2 questions pour ne pas passer à côté d'un 🐺

Comment thread itou/templates/signup/includes/no_email_link.html Outdated
Comment thread itou/www/signup/forms.py Outdated
@hellodeloo
hellodeloo force-pushed the deloo/ux-improvement-of-signup-forms branch from 7e90e23 to e6d9af2 Compare March 3, 2025 16:23
@hellodeloo
hellodeloo requested a review from vincentporte March 3, 2025 16:34

@vincentporte vincentporte left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 LGTM

@xavfernandez xavfernandez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sauf si on souhaite explicitement avoir des attributs placeholder="" dans l'HTML, il vaut mieux supprimer directement toutes les lignes qui définissent un placeholder vide.

Comment thread itou/www/signup/forms.py Outdated
Comment thread itou/www/signup/forms.py Outdated
Comment thread itou/www/signup/forms.py Outdated
Comment thread itou/templates/signup/includes/no_email_link.html Outdated
Comment thread itou/www/signup/forms.py Outdated
Comment thread itou/www/signup/forms.py
@hellodeloo
hellodeloo force-pushed the deloo/ux-improvement-of-signup-forms branch 8 times, most recently from fd9cc3c to 5ae7c18 Compare March 6, 2025 13:57
@hellodeloo
hellodeloo requested a review from xavfernandez March 6, 2025 14:05
Comment thread itou/www/signup/forms.py Outdated
@hellodeloo
hellodeloo force-pushed the deloo/ux-improvement-of-signup-forms branch from 5ae7c18 to 503065c Compare March 6, 2025 14:34
@hellodeloo
hellodeloo requested a review from xavfernandez March 6, 2025 14:35
@hellodeloo
hellodeloo added this pull request to the merge queue Mar 6, 2025
Merged via the queue into master with commit 64245aa Mar 6, 2025
@hellodeloo
hellodeloo deleted the deloo/ux-improvement-of-signup-forms branch March 6, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC modifié Modifié dans le changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants