Skip to content

UX/UI: Correction du formulaire critères administratifs GEIQ#5697

Merged
hellodeloo merged 1 commit into
masterfrom
deloo/fix-geiq-administrative-criteria-form-ui
Mar 6, 2025
Merged

UX/UI: Correction du formulaire critères administratifs GEIQ#5697
hellodeloo merged 1 commit into
masterfrom
deloo/fix-geiq-administrative-criteria-form-ui

Conversation

@hellodeloo

@hellodeloo hellodeloo commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

🤔 Pourquoi ?

Plusieurs défauts de mise en forme à corriger

  • les checkbox se déformaient a cause de l’application de la class .has-spinner-loading utilisée par htmx directement sur les inputs (au lieu du <div> parent comme pour le radio oui/non de la première question)
  • certains espacements n'étaient pas bons
  • le contenu du help_text n'était pas visuellement "disabled" quand le input + label était "disabled" (maj du thème)

@hellodeloo hellodeloo self-assigned this Feb 26, 2025
@hellodeloo hellodeloo changed the title Deloo/fix geiq administrative criteria form UI UX/UI: Correction du formulaire critères administratifs GEIQ Feb 26, 2025
@hellodeloo hellodeloo added the modifié Modifié dans le changelog. label Feb 26, 2025
@notion-workspace

Copy link
Copy Markdown

@hellodeloo hellodeloo force-pushed the deloo/fix-geiq-administrative-criteria-form-ui branch from 6d3408b to ce72472 Compare February 26, 2025 15:07
Comment thread itou/www/geiq_eligibility_views/forms.py

@vincentporte vincentporte left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 LGTM

Comment thread itou/www/geiq_eligibility_views/forms.py
Comment thread itou/www/geiq_eligibility_views/forms.py Outdated
Comment thread itou/www/geiq_eligibility_views/forms.py
@hellodeloo hellodeloo force-pushed the deloo/fix-geiq-administrative-criteria-form-ui branch from ce72472 to 1365083 Compare March 6, 2025 15:37
@hellodeloo hellodeloo force-pushed the deloo/fix-geiq-administrative-criteria-form-ui branch from 1365083 to eaa348b Compare March 6, 2025 15:49
@hellodeloo hellodeloo added this pull request to the merge queue Mar 6, 2025
Merged via the queue into master with commit 78d796c Mar 6, 2025
@hellodeloo hellodeloo deleted the deloo/fix-geiq-administrative-criteria-form-ui branch March 6, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modifié Modifié dans le changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants