GPS: Permettre l'ajout de bénéficiaire#5709
Merged
Merged
Conversation
tonial
added
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
tonial
force-pushed
the
alaurent/gps_add_beneficiary_1
branch
6 times, most recently
from
March 5, 2025 05:34
6673a83 to
ef41d2a
Compare
tonial
marked this pull request as ready for review
March 5, 2025 05:35
tonial
force-pushed
the
alaurent/gps_add_beneficiary_1
branch
6 times, most recently
from
March 6, 2025 08:43
8212821 to
09d2c1c
Compare
xavfernandez
reviewed
Mar 6, 2025
tonial
force-pushed
the
alaurent/gps_add_beneficiary_1
branch
5 times, most recently
from
March 6, 2025 15:45
9f3483b to
99ccdc8
Compare
tonial
force-pushed
the
alaurent/gps_mask_unless
branch
2 times, most recently
from
March 6, 2025 20:21
5cd3e62 to
ea18cae
Compare
tonial
force-pushed
the
alaurent/gps_add_beneficiary_1
branch
3 times, most recently
from
March 11, 2025 06:26
e6a8987 to
095f498
Compare
|
|
||
| def autocomplete_display(self): | ||
| # Not the same output as the autocomplete but close enough | ||
| return self.get_full_name() |
Contributor
There was a problem hiding this comment.
Je me demande si ça ne permet pas à l'orienteur de contourner les règles de can_view_personal_information ?
Contributor
Author
There was a problem hiding this comment.
Après, vu notre formulaire, on ne peut pas avoir d'erreur de saisie, donc on ne devrait utiliser ce fallback, si ?
Contributor
Author
There was a problem hiding this comment.
Ah, si c'est possible en donnant un choix invalide et ça fait une IDOR où je post une PK et j'obtiens un nom complet.
Comme on ne peut voir ce nom que si on fait exprès de mettre une valeur invalide, je vais afficher "choix invalide" à la place (cf dernier commit)
tonial
force-pushed
the
alaurent/gps_add_beneficiary_1
branch
3 times, most recently
from
March 12, 2025 05:01
365e944 to
376df3a
Compare
tonial
force-pushed
the
alaurent/gps_add_beneficiary_1
branch
from
March 12, 2025 11:03
376df3a to
f4f6b81
Compare
We now filter on the user collegues followed beneficiaries
Only for authorized prescribers and employers
tonial
force-pushed
the
alaurent/gps_add_beneficiary_1
branch
from
March 13, 2025 06:22
f4f6b81 to
bcdf737
Compare
xavfernandez
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Avec 3 cas de figures:
https://www.notion.so/gip-inclusion/Reprendre-le-flux-d-ajout-de-b-n-ficiaire-pour-tout-le-monde-1835f321b6048043bed7efde05c8f643?pvs=4
figma : https://www.figma.com/design/qgmw6ZTrDRARTNO5yRF1kW/%F0%9F%A7%AD-B%C3%A9n%C3%A9ficiaires?node-id=633-18340&m=dev
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran