Admin: Remplacer la page de connexion de l'admin#5727
Merged
Conversation
leo-naeka
reviewed
Mar 6, 2025
Contributor
leo-naeka
left a comment
leo-naeka
left a comment
There was a problem hiding this comment.
Il faudra reword les commit messages :
login: Clean usuned context→login: Clean unused contextlogin: Replace amdin login view→login: Replace admin login view
tonial
force-pushed
the
alaurent/staff_login
branch
from
9d56016 to
aba5536
Compare
leo-naeka
approved these changes
Mar 6, 2025
2 tasks
tonial
force-pushed
the
alaurent/staff_login
branch
from
aba5536 to
cf40b8f
Compare
EwenKorr
approved these changes
Mar 7, 2025
Contributor
EwenKorr
left a comment
EwenKorr
left a comment
There was a problem hiding this comment.
Je trouve que c'est une bonne idée !
This will allow us to use it instead of the admin login view We will then be able to add the OTP check view outside of the admin
Using the perms middleware. We can now go to a specific admin page (eg /admin/users/user/PK) and be redirected to a login page that will redirect us back to the correct page. Before this commit, when accessing such page, we would have the generic login page that does not have a "staff login" link
tonial
force-pushed
the
alaurent/staff_login
branch
from
cf40b8f to
e7671f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour nous permettre d'ajouter la vérification OTP plus proprement, et de manière à pouvoir le généraliser à d'autres utilisateurs un jour
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran