Employeur : empêcher l'envoi de candidatures en cours dès que l'employeur ferme les offres#5748
Merged
EwenKorr merged 1 commit intoApr 8, 2025
Conversation
calummackervoy
added
the
no-changelog
2 tasks
calummackervoy
force-pushed
the
calum/close-spontaneous-applications-mid-application
branch
from
March 11, 2025 13:37
7abfbf5 to
a04472c
Compare
calummackervoy
marked this pull request as ready for review
March 11, 2025 13:38
calummackervoy
force-pushed
the
calum/close-spontaneous-applications-mid-application
branch
from
March 25, 2025 11:04
a04472c to
f7b4977
Compare
EwenKorr
reviewed
Mar 25, 2025
calummackervoy
force-pushed
the
calum/close-spontaneous-applications-mid-application
branch
2 times, most recently
from
March 26, 2025 17:46
8a60981 to
33da49d
Compare
calummackervoy
commented
Mar 26, 2025
EwenKorr
changed the title
Contributor
|
Une autre relecture peut-être ? |
xavfernandez
approved these changes
Mar 31, 2025
EwenKorr
force-pushed
the
calum/close-spontaneous-applications-mid-application
branch
from
April 1, 2025 15:10
33da49d to
899240c
Compare
hellodeloo
approved these changes
Apr 1, 2025
EwenKorr
force-pushed
the
calum/close-spontaneous-applications-mid-application
branch
from
April 3, 2025 13:45
899240c to
9e9ea4f
Compare
EwenKorr
enabled auto-merge
April 3, 2025 13:47
EwenKorr
force-pushed
the
calum/close-spontaneous-applications-mid-application
branch
from
April 3, 2025 14:03
9e9ea4f to
d05a0d8
Compare
EwenKorr
added this pull request to the merge queue
Apr 3, 2025
| is_active=False, | ||
| pk__in=self.apply_session.get("selected_jobs", []), | ||
| ).exists(): | ||
| messages.error(request, apply_view_constants.ERROR_EMPLOYER_BLOCKING_APPLICATIONS_FOR_JOB_DESCRIPTION) |
Member
There was a problem hiding this comment.
On pourrait être plus précis en incluant les libellés des jobs inactifs 🤷
francoisfreitag
removed this pull request from the merge queue due to a manual request
Apr 3, 2025
Member
|
Je viens juste de poster une revue, j’ai retiré de la merge queue pour que tu puisses voir les commentaires et décider de ce que tu appliques ou non. |
Member
There was a problem hiding this comment.
Idéalement, on aurait au moins un test sur ApplicationEligibilityView, histoire que la modification suivante échoue dans la CI.
diff --git a/itou/www/apply/views/submit_views.py b/itou/www/apply/views/submit_views.py
index 6d572272b..aca8f9ab9 100644
--- a/itou/www/apply/views/submit_views.py
+++ b/itou/www/apply/views/submit_views.py
@@ -463,7 +463,7 @@ class RequireValidApplySessionMixin:
return super().dispatch(request, *args, **kwargs)
-class ApplicationEligibilityView(RequireValidApplySessionMixin, ApplicationBaseView):
+class ApplicationEligibilityView(ApplicationBaseView):
template_name = "apply/submit/application/eligibility.html"
def __init__(self):
Member
J’ai |
EwenKorr
force-pushed
the
calum/close-spontaneous-applications-mid-application
branch
from
April 4, 2025 14:24
d05a0d8 to
ad8859b
Compare
Contributor
|
Dans les commits fixups :
Je vais laisser de côté les libellés des jobs inactifs. |
francoisfreitag
approved these changes
Apr 7, 2025
Comment on lines
+71
to
+72
| def no_available_jobs(self): | ||
| return not self.fields.get("spontaneous_application") and not self.fields["selected_jobs"].choices |
Member
There was a problem hiding this comment.
Pour éviter les doubles négations, je l’aurais appelé jobs_available. 🤷
Extends mixin to require session is valid with regards to selected job and active company blocks
EwenKorr
force-pushed
the
calum/close-spontaneous-applications-mid-application
branch
from
April 7, 2025 09:43
61f0cc8 to
d9cf6ef
Compare
EwenKorr
added this pull request to the merge queue
Apr 7, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 7, 2025
EwenKorr
added this pull request to the merge queue
Apr 8, 2025
EwenKorr
deleted the
calum/close-spontaneous-applications-mid-application
branch
April 8, 2025 07:08
EwenKorr
added
modifié
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Suite au #5698, on a décidé de mettre ce changement dans un seconde PR
🚨 À vérifier
💻 Captures d'écran