Demandeur d’emploi : Empêcher l’édition de l’identité pivot pour les candidats identifiés par l’API Particulier [GEN-1380]#5749
Merged
Conversation
francoisfreitag
changed the title
Member
Author
|
Je préparerai une recette jetable avec des belles données factices jeudi. |
Contributor
|
Il manque le message expliquant pourquoi les champs ne sont pas modifiables non ? |
Member
Author
|
En effet, merci. C'était le plus facile alors je l'ai occulté 🫣 |
francoisfreitag
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
francoisfreitag
force-pushed
the
ff/ro-fields-2
branch
2 times, most recently
from
ce6a55a to
87dc1c8
Compare
celine-m-s
reviewed
Mar 20, 2025
francoisfreitag
force-pushed
the
ff/ro-fields-2
branch
2 times, most recently
from
d5f7bb3 to
d99a013
Compare
Member
Author
|
@celine-m-s J’ai fait des fixups, je squasherai quand tu auras revu et sera d’accord :) |
celine-m-s
approved these changes
Mar 25, 2025
Contributor
|
C'est tout bon pour moi ! :) 🚀 |
Member
Author
|
Joffrey est sur le coup (via la recette jetable) ! |
francoisfreitag
force-pushed
the
ff/ro-fields-2
branch
from
ea41093 to
9d9d306
Compare
francoisfreitag
force-pushed
the
ff/ro-fields-2
branch
from
9d9d306 to
a4b5ce3
Compare
Member
Author
|
Je viens d’ajouter un commit a939b1d @celine-m-s L’idée est de bloquer l’édition des informations personnelles dès qu’un candidat est reconnu, peu importe s’il a un critère certifié. |
francoisfreitag
changed the title
francoisfreitag
added a commit
that referenced
this pull request
Apr 7, 2025
This denormalized field caches when a job seeker has been recognized by an external identity certifier. It means that person is known from trusted identity referential and their identity should not change. An upcoming migration will populate the field, and #5749 will rely on it.
francoisfreitag
added a commit
that referenced
this pull request
Apr 7, 2025
When a job seeker identity is certified by an external source, populate this field to record when the certification occurred. This will be used for several purposes: 1. Centralize certification to make corresponding fields read only, and providing details to users 2. Prevent users from changing identities after the system has confirmed their eligibility (eg. BRSA on API Particulier) 3. Refresh certified identities once in a while 4. When the CNAV identity provider is available, the certified fields should depend on each user. Using a ManyToManyField with a through table will facilitate storing what fields have been certified. An upcoming migration will populate the field, and #5749 will rely on it.
francoisfreitag
added a commit
that referenced
this pull request
Apr 7, 2025
When a job seeker identity is certified by an external source, populate this field to record when the certification occurred. This will be used for several purposes: 1. Centralize certification to make corresponding fields read only, and providing details to users 2. Prevent users from changing identities after the system has confirmed their eligibility (eg. BRSA on API Particulier) 3. Refresh certified identities once in a while 4. When the CNAV identity provider is available, the certified fields should depend on each user. Using a ManyToManyField with a through table will facilitate storing what fields have been certified. An upcoming migration will populate the field, and #5749 will rely on it.
francoisfreitag
added a commit
that referenced
this pull request
Apr 7, 2025
When a job seeker identity is certified by an external source, populate this field to record when the certification occurred. This will be used for several purposes: 1. Centralize certification to make corresponding fields read only, and providing details to users 2. Prevent users from changing identities after the system has confirmed their eligibility (eg. BRSA on API Particulier) 3. Refresh certified identities once in a while 4. When the CNAV identity provider is available, the certified fields should depend on each user. Using a ManyToManyField with a through table will facilitate storing what fields have been certified. An upcoming migration will populate the field, and #5749 will rely on it.
francoisfreitag
added a commit
that referenced
this pull request
Apr 7, 2025
When a job seeker identity is certified by an external source, populate this field to record when the certification occurred. This will be used for several purposes: 1. Centralize certification to make corresponding fields read only, and providing details to users 2. Prevent users from changing identities after the system has confirmed their eligibility (eg. BRSA on API Particulier) 3. Refresh certified identities once in a while 4. When the CNAV identity provider is available, the certified fields should depend on each user. Using a ManyToManyField with a through table will facilitate storing what fields have been certified. An upcoming migration will populate the field, and #5749 will rely on it.
francoisfreitag
added a commit
that referenced
this pull request
Apr 7, 2025
When a job seeker identity is certified by an external source, populate this field to record when the certification occurred. This will be used for several purposes: 1. Centralize certification to make corresponding fields read only, and providing details to users 2. Prevent users from changing identities after the system has confirmed their eligibility (eg. BRSA on API Particulier) 3. Refresh certified identities once in a while 4. When the CNAV identity provider is available, the certified fields should depend on each user. Using a ManyToManyField with a through table will facilitate storing what fields have been certified. An upcoming migration will populate the field, and #5749 will rely on it.
francoisfreitag
force-pushed
the
ff/ro-fields-2
branch
2 times, most recently
from
7b2ac25 to
cf3764d
Compare
Member
Author
|
Je crois avoir pris en compte toute tes remarques avec les derniers fixups ? |
francoisfreitag
added a commit
that referenced
this pull request
Apr 14, 2025
The birthdate was treated separately, and multiple code path had to act special case that field. A new code path would again have to special case that field: #5749 (comment) Instead, dispatch data from the SSO: - `sso_data_dict` comes from the SSO (excluding empty values) - `user_data_dict` stores User data - `jobseeker_data_dict` stores JobSeekerProfile data
francoisfreitag
added a commit
that referenced
this pull request
Apr 14, 2025
The birthdate was treated separately, and multiple code path had to act special case that field. A new code path would again have to special case that field: #5749 (comment) Instead, dispatch data from the SSO: - `sso_data_dict` comes from the SSO (excluding empty values) - `user_data_dict` stores User data - `jobseeker_data_dict` stores JobSeekerProfile data
francoisfreitag
added a commit
that referenced
this pull request
Apr 14, 2025
The birthdate was treated separately, and multiple code path had to act special case that field. A new code path would again have to special case that field: #5749 (comment) Instead, dispatch data from the SSO: - `sso_data_dict` comes from the SSO (excluding empty values) - `user_data_dict` stores User data - `jobseeker_data_dict` stores JobSeekerProfile data
francoisfreitag
added a commit
that referenced
this pull request
Apr 14, 2025
The birthdate was treated separately, and multiple code path had to act special case that field. A new code path would again have to special case that field: #5749 (comment) Instead, dispatch data from the SSO: - `sso_data_dict` comes from the SSO (excluding empty values) - `user_data_dict` stores User data - `jobseeker_data_dict` stores JobSeekerProfile data
francoisfreitag
added a commit
that referenced
this pull request
Apr 14, 2025
The birthdate was treated separately, and multiple code path had to act special case that field. A new code path would again have to special case that field: #5749 (comment) Instead, dispatch data from the SSO: - `sso_data_dict` comes from the SSO (excluding empty values) - `user_data_dict` stores User data - `jobseeker_data_dict` stores JobSeekerProfile data
francoisfreitag
added a commit
that referenced
this pull request
Apr 14, 2025
The birthdate was treated separately, and multiple code path had to act special case that field. A new code path would again have to special case that field: #5749 (comment) Instead, dispatch data from the SSO: - `sso_data_dict` comes from the SSO (excluding empty values) - `user_data_dict` stores User data - `jobseeker_data_dict` stores JobSeekerProfile data
francoisfreitag
added a commit
that referenced
this pull request
Apr 14, 2025
The birthdate was treated separately, and multiple code path had to act special case that field. A new code path would again have to special case that field: #5749 (comment) Instead, dispatch data from the SSO: - `sso_data_dict` comes from the SSO (excluding empty values) - `user_data_dict` stores User data - `jobseeker_data_dict` stores JobSeekerProfile data
francoisfreitag
force-pushed
the
ff/ro-fields-2
branch
2 times, most recently
from
280c141 to
f433486
Compare
francoisfreitag
added a commit
that referenced
this pull request
Apr 15, 2025
The birthdate was treated separately, and multiple code path had to act special case that field. A new code path would again have to special case that field: #5749 (comment) Instead, dispatch data from the SSO: - `sso_data_dict` comes from the SSO (excluding empty values) - `user_data_dict` stores User data - `jobseeker_data_dict` stores JobSeekerProfile data
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
The birthdate was treated separately, and multiple code path had to act special case that field. A new code path would again have to special case that field: #5749 (comment) Instead, dispatch data from the SSO: - `sso_data_dict` comes from the SSO (excluding empty values) - `user_data_dict` stores User data - `jobseeker_data_dict` stores JobSeekerProfile data
francoisfreitag
force-pushed
the
ff/ro-fields-2
branch
2 times, most recently
from
950f353 to
30e6488
Compare
Member
Author
|
Je viens d’ajouter 30e6488, je vais le squash une fois qu’il sera relu. |
francoisfreitag
force-pushed
the
ff/ro-fields-2
branch
from
30e6488 to
1276648
Compare
| "fields_history_formatted", | ||
| ] | ||
| if obj: | ||
| readonly_fields.extend(obj.readonly_pii_fields()) |
Contributor
There was a problem hiding this comment.
Django ne se plaint pas quand on lui fournit le nom d'un champ qui n'existe pas sur le modèle ? (birthdate pour User ou first_name pour JobSeekerProfile)
xavfernandez
approved these changes
Apr 17, 2025
francoisfreitag
removed
the
1-recette-jetable
francoisfreitag
force-pushed
the
ff/ro-fields-2
branch
from
1276648 to
1a10198
Compare
The job seeker identity is used to certify eligibility against the API Particuliers. When eligibility is certified, the hire will be removed from siae evaluations. In order to prevent employers to reuse an identity for multiple job seekers, make sure the job seeker personal data is locked when their eligibility has been confirmed. Also, since the job seeker has been found in an external certification authority, make their fields read-only to increase the likelihood of success for next API particulier calls. To better show the dependency between read-only form fields and the API Particuliers, factor out the required fields for the API into constants that can be reused across the codebase.
francoisfreitag
force-pushed
the
ff/ro-fields-2
branch
from
1a10198 to
b61c356
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Les candidats dont l’identité a été reconnue par l’API particulier ne doivent plus pouvoir changer d’identité.
🏝️ Comment tester ?
Bien penser aux cas suivants :
💻 Captures d'écran
Details