Candidature : ajouter back_url sur les boutons Postuler#5804
Merged
Conversation
EwenKorr
force-pushed
the
ewen/keep_applying_for
branch
4 times, most recently
from
19f71be to
9c84fed
Compare
EwenKorr
commented
Mar 24, 2025
| @@ -120,20 +120,9 @@ def get_back_url(self): | |||
| return None | |||
|
|
|||
| def get_reset_url(self): | |||
Contributor
Author
There was a problem hiding this comment.
Il y a sans doute une marge d'amélioration.
Est-ce qu'on assume qu'on passe toujours un back_url en paramètre GET, et qu'on peut faire fi des if et du retour au dashboard le cas échéant ?
EwenKorr
force-pushed
the
ewen/keep_applying_for
branch
from
9c84fed to
bcac73d
Compare
xavfernandez
approved these changes
Mar 24, 2025
leo-naeka
approved these changes
Mar 24, 2025
Comment on lines
+272
to
+280
| pytest.param("", "", {}, id="EmptySession"), | ||
| pytest.param(1, "", {"selected_jobs": [1]}, id="SessionWithSelectedJobs"), | ||
| pytest.param( | ||
| 1, | ||
| "/une/url/quelconque", | ||
| {"selected_jobs": [1], "reset_url": "/une/url/quelconque"}, | ||
| id="SessionWithSelectJobsAndResetUrl", | ||
| ), | ||
| pytest.param("", "/une/url/quelconque", {"reset_url": "/une/url/quelconque"}, id="SessionWithResetUrl"), |
Contributor
There was a problem hiding this comment.
nit: plutôt du snake case pour les IDs ?
Je pense que tu peux aussi drop le préfixe "Session" vu que le nom complet est dérivé du nom du test
Contributor
Author
There was a problem hiding this comment.
Il y a une sacrée diversité de format dans les ID des parametrize 😁
Mais je rejoins ton équipe ! :)
If `job_description_id` is passed: a session is initialized, otherwise it is not.
This session will be systematically filled in a later commit.
In order to correctly be sent back to this page when cancelling an application, as well as to keep the banner "Vous postulez actuellement pour…".
EwenKorr
force-pushed
the
ewen/keep_applying_for
branch
from
bcac73d to
d369a44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Je vois deux petits problèmes au fonctionnement actuel :
🍰 Comment ?
Une solution est d'ajouter le traditionnel (mais controversé ?)
?back_url=aux boutons Postuler.La vue
StartViewinsère dansapply_sessioncette info dansreset_url.🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran