Création du composant c-title et mise a jour des templates static et companies - #5806
Merged
Merged
Conversation
hellodeloo
force-pushed
the
deloo/add-title-slippers-component
branch
from
March 21, 2025 13:30
3d4e03d to
0ead4a3
Compare
hellodeloo
changed the title
hellodeloo
marked this pull request as draft
March 21, 2025 16:22
hellodeloo
force-pushed
the
deloo/add-title-slippers-component
branch
3 times, most recently
from
April 1, 2025 13:25
225c39c to
3697dcd
Compare
hellodeloo
marked this pull request as ready for review
April 1, 2025 13:34
hellodeloo
force-pushed
the
deloo/add-title-slippers-component
branch
2 times, most recently
from
April 1, 2025 14:21
c84abf3 to
884ff53
Compare
hellodeloo
added
1-recette-jetable
hellodeloo
requested review from
EwenKorr,
leo-naeka,
tonial,
vincentporte and
xavfernandez
April 1, 2025 14:44
hellodeloo
added
1-recette-jetable
EwenKorr
added
1-recette-jetable
hellodeloo
force-pushed
the
deloo/add-title-slippers-component
branch
from
April 1, 2025 16:02
884ff53 to
6ffaa7b
Compare
xavfernandez
force-pushed
the
deloo/add-title-slippers-component
branch
from
April 3, 2025 07:04
6ffaa7b to
eb2002d
Compare
xavfernandez
reviewed
Apr 3, 2025
hellodeloo
force-pushed
the
deloo/add-title-slippers-component
branch
5 times, most recently
from
April 4, 2025 15:36
c783ba2 to
7390bf0
Compare
hellodeloo
changed the title
hellodeloo
force-pushed
the
deloo/add-title-slippers-component
branch
from
April 4, 2025 15:41
7390bf0 to
4b2b069
Compare
xavfernandez
reviewed
Apr 4, 2025
| <p> | ||
| Le site des emplois de l'inclusion est d’accès libre et gratuit à tout Utilisateur. La simple visite des emplois de l'inclusion suppose l’acceptation par tout Utilisateur des présentes conditions générales d’utilisation. | ||
| </p> | ||
| <p>Le site des emplois de l'inclusion est d’accès libre et gratuit à tout Utilisateur. La simple visite des emplois de l'inclusion suppose l’acceptation par tout Utilisateur des présentes conditions générales d’utilisation.</p> |
Contributor
There was a problem hiding this comment.
👀 Beaucoup de déplacements sans rapport ?
| </h1> | ||
| {% endfragment %} | ||
| {% fragment as c_title__cta %} | ||
| {% if can_update_job_description %} |
Contributor
There was a problem hiding this comment.
Est-ce que ça n'aurait pas du sens de ne définir le fragment (et avoir un div cta que si can_update_job_description est vrai) ?
hellodeloo
force-pushed
the
deloo/add-title-slippers-component
branch
from
April 4, 2025 17:06
4b2b069 to
faae23d
Compare
hellodeloo
requested review from
xavfernandez
and removed request for
leo-naeka and
vincentporte
April 4, 2025 17:16
hellodeloo
force-pushed
the
deloo/add-title-slippers-component
branch
from
April 7, 2025 12:12
faae23d to
3651092
Compare
hellodeloo
force-pushed
the
deloo/add-title-slippers-component
branch
2 times, most recently
from
April 7, 2025 12:16
dad3910 to
83f40bc
Compare
hellodeloo
added this pull request to the merge queue
Apr 7, 2025
hellodeloo
removed this pull request from the merge queue due to a manual request
Apr 7, 2025
francoisfreitag
approved these changes
Apr 7, 2025
francoisfreitag
left a comment
francoisfreitag
left a comment
Member
There was a problem hiding this comment.
Merci pour le découpage, ça rend les changements bien plus facile à relire !
J’ai ouvert ceux qui me semblaient utile de vérifier dans un navigateur sans voir de souci :
- page entreprise
- fiche de poste
- accessibilité
- terms
| {% if can_update_job_description %} | ||
| <a href="{% url "companies_views:update_job_description" job_description_id=job.pk %}" | ||
| class="btn btn-lg btn-block btn-primary btn-ico" | ||
| class="btn btn-lg btn-primary btn-ico" |
| <h1> | ||
| {{ job.display_name }} | ||
| {% if job.is_active %} | ||
| <span class="badge badge-base rounded-pill bg-success"> |
Member
There was a problem hiding this comment.
Une des classes a été ajoutée lors de la transformation (badge-base IIRC)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour faciliter l'intégration des composants du thème et éviter les incohérences de UI
🍰 Comment ?
Recette jetable > https://c1-review-deloo-add-title-slippers-component.cleverapps.io/search/employers