Prescripteur: Pouvoir valider l’éligibilité IAE sans être dans le parcours Postuler [GEN-825]#5809
Merged
Conversation
tonial
added
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
EwenKorr
reviewed
Mar 24, 2025
tonial
force-pushed
the
alaurent/update_diag
branch
from
d9dc7aa to
01a88b3
Compare
tonial
force-pushed
the
alaurent/update_diag
branch
2 times, most recently
from
f3bf321 to
aba19be
Compare
tonial
force-pushed
the
alaurent/update_diag
branch
2 times, most recently
from
4b23b46 to
41a054d
Compare
EwenKorr
approved these changes
Mar 25, 2025
EwenKorr
left a comment
EwenKorr
left a comment
Contributor
There was a problem hiding this comment.
À part des petites typo ça me paraît bon ! 👍
| response = client.get(url) | ||
| assert str(parse_response_to_soup(response, "#main")) == snapshot | ||
|
|
||
| IAEEligibilityDiagnosisFactory(job_seeker=job_seeker, from_prescriber=True, expired=True) |
Contributor
There was a problem hiding this comment.
Besoin de créer un diag ici ?
Contributor
There was a problem hiding this comment.
Ah, c'est pour vérifier que le last_considered_valid() renvoie bien le nouveau ?
Contributor
Author
There was a problem hiding this comment.
Je voulais vérifier qu'un diag expiré n'est pas utilisé (et on a donc la même page que sans diag) mais une partie du test manquait :
response = client.get(url)
assert str(parse_response_to_soup(response, "#main")) == snapshot
When adding a job seeker (standalone_creation): if he already exists, the prescriber can add him to his job seeker list by making an eligibility diagnosis
tonial
force-pushed
the
alaurent/update_diag
branch
from
41a054d to
7e27a90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour l'instant la vue n'est pas réutilisée dans le parcours de candidature.
Ce sera fait dans un second temps comme ça on débloque cette fonctionnalité sans attendre.
Cette seconde partie est en draft dans la PR #5810. Il reste cependant des éléments à éclaircir pour fluidifier le passage d'un "module" métier à l'autre.
Pour tester : se connecter avec un compte prescripteur et aller dans l'espace candidat:
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran