GPS: Empêcher les relations en double#5868
Merged
Merged
Conversation
tonial
force-pushed
the
alaurent/gps_new_advisor_file
branch
2 times, most recently
from
e10cef7 to
4a09d35
Compare
tonial
force-pushed
the
alaurent/gps_constraint
branch
from
96c435d to
53ed1c0
Compare
tonial
force-pushed
the
alaurent/gps_constraint
branch
from
53ed1c0 to
8c1f634
Compare
tonial
force-pushed
the
alaurent/gps_new_advisor_file
branch
from
4a09d35 to
286dcc4
Compare
tonial
force-pushed
the
alaurent/gps_constraint
branch
from
8c1f634 to
d353b39
Compare
tonial
force-pushed
the
alaurent/gps_new_advisor_file
branch
from
286dcc4 to
672dc9b
Compare
xavfernandez
approved these changes
Apr 3, 2025
francoisfreitag
left a comment
francoisfreitag
left a comment
Member
There was a problem hiding this comment.
Le commit fixup! gps: Add management command for new advisor file était pour une autre PR non ?
francoisfreitag
approved these changes
Apr 3, 2025
tonial
force-pushed
the
alaurent/gps_new_advisor_file
branch
2 times, most recently
from
7fab38a to
c0c7002
Compare
tonial
force-pushed
the
alaurent/gps_constraint
branch
from
d353b39 to
65eca74
Compare
EwenKorr
approved these changes
Apr 3, 2025
Contributor
Author
|
@francoisfreitag oui, pour une PR en dessous (j'en ai encore 4 qui se suivent 🙈 ) |
tonial
force-pushed
the
alaurent/gps_constraint
branch
2 times, most recently
from
5648c02 to
4308797
Compare
Member
|
Plus je regarde cette PR, plus elle a de commits 😨 |
tonial
force-pushed
the
alaurent/gps_new_advisor_file
branch
from
c0c7002 to
05aa292
Compare
Contributor
Author
|
C'est bon, je viens de repusher toutes les PR d'en dessous 👼 |
Contributor
Author
|
C'est cool le |
tonial
force-pushed
the
alaurent/gps_new_advisor_file
branch
from
05aa292 to
7e51cca
Compare
tonial
force-pushed
the
alaurent/gps_constraint
branch
from
4308797 to
2850359
Compare
tonial
force-pushed
the
alaurent/gps_new_advisor_file
branch
from
7e51cca to
f7b00c1
Compare
tonial
force-pushed
the
alaurent/gps_constraint
branch
2 times, most recently
from
982c8b1 to
dbb1a85
Compare
tonial
force-pushed
the
alaurent/gps_new_advisor_file
branch
from
f7b00c1 to
74fe84a
Compare
tonial
force-pushed
the
alaurent/gps_constraint
branch
from
dbb1a85 to
d27ed4c
Compare
tonial
force-pushed
the
alaurent/gps_new_advisor_file
branch
2 times, most recently
from
b775829 to
ebbf16f
Compare
tonial
force-pushed
the
alaurent/gps_constraint
branch
from
d27ed4c to
5c27be7
Compare
tonial
force-pushed
the
alaurent/gps_new_advisor_file
branch
from
ebbf16f to
7cd9976
Compare
This is to prevent our admin from creating a membership that already exists There are 80 duplicated memberships, hence the script to clean duplicates
tonial
force-pushed
the
alaurent/gps_constraint
branch
from
5c27be7 to
2f47b9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour empêcher louis-jean de créer des relations en double dans l'admin
https://www.notion.so/gip-inclusion/Emp-cher-les-relations-en-double-1c85f321b6048083bf4ad3c708ef8157?pvs=4
🍰 Comment ?
Ajout d'un unique_together
🚨 À vérifier
🏝️ Comment tester ?
Se connect à l'admin, prendre une relation GPS existante (http://127.0.0.1:8000/admin/gps/followupgroupmembership/)
et en ajouter une avec le même groupe et le même membre.
Un message d'erreur s'affiche et l'objet n'est pas créé.
💻 Captures d'écran