Notifications: Correction de la liste d'envoi de la notification de rappel périodique pour s'assurer que les membres de sa structure sont bien actifs et autorisés#5956
Merged
Conversation
tonial
force-pushed
the
alaurent/fix_notifications
branch
from
01056c3 to
d1c75ec
Compare
If a user is still an admin in at least one organization, we used to send him notifications for all the organization he was a member of
tonial
force-pushed
the
alaurent/fix_notifications
branch
from
d1c75ec to
01c2e44
Compare
xavfernandez
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Le queryset actuel récupère la liste de tous les membres des organisations qui sont admin d'au moins une organization.
On se retrouve donc à envoyer la notification à des membres non admin ou même des anciens members d'une organization parce qu'ils sont admin d'une autre organization.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran