Statistiques : Migrer le NPS de Hotjar vers Tally [GEN-2357] - #5959
Merged
Merged
Conversation
dejafait
marked this pull request as draft
April 14, 2025 13:48
dejafait
force-pushed
the
dejafait/nps_tally
branch
3 times, most recently
from
April 14, 2025 14:18
b5551e1 to
02d3f11
Compare
dejafait
marked this pull request as ready for review
April 14, 2025 14:34
dejafait
force-pushed
the
dejafait/nps_tally
branch
from
April 14, 2025 14:42
02d3f11 to
835bf0b
Compare
xavfernandez
approved these changes
Apr 17, 2025
xavfernandez
left a comment
xavfernandez
left a comment
Contributor
There was a problem hiding this comment.
Je découvre currentScript.dataset pour passer des arguments à un script 👍
Ça m'a l'air ma foi de bien marcher mais je ne suis pas non plus un expert JS 😬
| }; | ||
| }; | ||
|
|
||
| window.TallyConfig = tallyConfig; |
Contributor
There was a problem hiding this comment.
Je me demande dans quelle mesure on ne devrait pas passer à Tally.openPopup() qui est documenté (contrairement à window.TallyConfig) mais bon tant que ça fonctionne 🤷♂️
Co-authored-by: Xavier Fernandez <xavier.fernandez@beta.gouv.fr>
dejafait
force-pushed
the
dejafait/nps_tally
branch
from
April 17, 2025 13:50
4e3c44c to
7d70d78
Compare
dejafait
enabled auto-merge
April 17, 2025 13:56
dejafait
added this pull request to the merge queue
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
On est en train de quitter Hotjar. 🔪
🍰 Comment ?
J'ai ajouté un script
nps_popup.jsstatique qui prend quelques paramètres.Je ne suis pas très à l'aise en js donc ne pas hésiter à me dire si j'aurai du faire autrement.
💻 Captures d'écran
page liste candidatures, employeur
page dépôt de candidature, prescripteur
les
hiddenFieldsarrivent bien à destination