[GEN-2321] Stabilité: traitement des logs de Import EA EATT#5979
Merged
Conversation
vincentporte
force-pushed
the
vp/GEN-2321_automatisation_import_EA_EATT
branch
from
842facc to
01e2b01
Compare
vincentporte
force-pushed
the
vp/GEN-2321_automatisation_import_EA_EATT
branch
from
01e2b01 to
de50b7d
Compare
rsebille
reviewed
Apr 23, 2025
rsebille
left a comment
rsebille
left a comment
Contributor
There was a problem hiding this comment.
Un peu (beaucoup) circonspect sur le fait d'avoir mis toutes les variables dans extra, car j'ai pas l'impression qu'on y gagne voir même que ça nuirais à la lecture des logs car on cache les détails, et quand ça ne fonctionne pas c'est souvent ça la cause ^^.
vincentporte
force-pushed
the
vp/GEN-2321_automatisation_import_EA_EATT
branch
2 times, most recently
from
1f4d427 to
03b30cb
Compare
vincentporte
force-pushed
the
vp/GEN-2321_automatisation_import_EA_EATT
branch
from
2d4bd8f to
a1af338
Compare
francoisfreitag
left a comment
francoisfreitag
left a comment
Member
There was a problem hiding this comment.
Ça m’a l’air bien. Quelques petites remarques pour peaufiner et je pense qu’on est bons 💯
Le commit “catch extra kwargs from management command” ne me semble plus utile ? On peut directement using re.compile in DJANGO_DATADOG_LOGGER_EXTRA_INCLUDE (avec un reword pour indiquer que itou a maintenant le droit d’ajouter des extra)
…a kwargs from itou loggers @francoisfreitag's suggestion Co-authored-by: François Freitag <mail@franek.fr>
vincentporte
force-pushed
the
vp/GEN-2321_automatisation_import_EA_EATT
branch
from
a1af338 to
e94636c
Compare
francoisfreitag
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
capturer les logs de la
commanddans le logger, en passant les données variables enkwargs🚨 À vérifier
Non Mettre à jour le CHANGELOG_breaking_changes.md ?
Non Ajouter l'étiquette « Bug » ?
🏝️ Comment tester ?