Candidature: Correction du badge d'éligibilité quand le PASS IAE est expiré [GEN-1462] - #5987
Merged
Conversation
tonial
marked this pull request as draft
April 17, 2025 14:33
tonial
force-pushed
the
alaurent/eligibility_badge
branch
2 times, most recently
from
April 18, 2025 13:02
e20cbc1 to
679d04d
Compare
tonial
marked this pull request as ready for review
April 18, 2025 13:06
the first asserts would still work even without calling with_list_related_data()
tonial
force-pushed
the
alaurent/eligibility_badge
branch
2 times, most recently
from
April 22, 2025 05:01
7e28a90 to
c3785aa
Compare
xavfernandez
approved these changes
Apr 22, 2025
xavfernandez
left a comment
xavfernandez
left a comment
Contributor
There was a problem hiding this comment.
A part le soucis de nommage, ça me semble top 👍
tonial
force-pushed
the
alaurent/eligibility_badge
branch
from
April 22, 2025 09:04
c3785aa to
c54078f
Compare
Some templates didn't use the same logic as eligibility_badge.html
tonial
force-pushed
the
alaurent/eligibility_badge
branch
from
April 22, 2025 12:38
c54078f to
3a27cb5
Compare
| {% if is_subject_to_eligibility_rules %} | ||
| {% if job_seeker.has_valid_approval %} | ||
| {% approval_state_badge job_seeker.latest_approval force_valid=force_valid span_extra_class=badge_class %} | ||
| {% approval_state_badge job_seeker.latest_approval force_valid=force_valid_approval span_extra_class=badge_class %} |
There was a problem hiding this comment.
comme job_seeker.has_valid_approval, force_valid=force_valid_approval n'est pas très utile ?
Contributor
Author
There was a problem hiding this comment.
force_valid=True fait qu'on affiche que le passe est valid sans préciser s'il est suspendu, futur, ou en cours.
C'est donc encore pertinent de le garder :)
xavfernandez
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
On ne veut plus marquer PASS expiré sur le badge, et laisser l'employeur avoir l'alerte qui lui dit de passer par un prescripteur habilité dans le parcours d'embauche.
J'ai donc revu ma copie
Si on a un diagnostic (de prescripteur?) valide, alors on est éligible, même si on a un PASS expiré dans le délais de carence.Le templateeligibility_badge.htmlest sacrément plus compliqué, et il manque un joli test pour tester toutes les combinaisons... j'attends un retour sur la carte notion🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran