Candidature: Protection contre les candidatures multiples (<24h) [GEN-2275] - #6077
Merged
Merged
Conversation
tonial
added
1-recette-jetable
xavfernandez
reviewed
May 5, 2025
| msg = "Vous avez déjà postulé chez cet employeur durant les dernières 24 heures." | ||
| else: | ||
| msg = "Ce candidat a déjà postulé chez cet employeur durant les dernières 24 heures." | ||
| self.apply_session.delete() # Don't allow to re-use the session in another step to skip this check |
Contributor
There was a problem hiding this comment.
Mais du coup si tu fais le step précédent puis le step suivant sans jamais faire de requête sur la vue CheckPreviousApplications, tu peux toujours éviter la limite non ?
Contributor
Author
There was a problem hiding this comment.
C'est bon, j'ai bougé le check dans le mixin de permissions
J'ai hésité à ne le mettre que dans ApplicationBaseView (vu que ce n'est pas nécessaire dans StartView no dans les vues qui héritent de ApplyStepForSenderBaseView mais ça me semblait quand même plus simple à relire de tout mettre au meme endroit.
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
tonial
force-pushed
the
alaurent/boost_apply_24h
branch
2 times, most recently
from
May 5, 2025 12:31
d797cdd to
73f9f09
Compare
xavfernandez
reviewed
May 5, 2025
tonial
force-pushed
the
alaurent/boost_apply_24h
branch
from
May 5, 2025 12:53
73f9f09 to
48e71a5
Compare
xavfernandez
reviewed
May 5, 2025
tonial
force-pushed
the
alaurent/boost_apply_24h
branch
from
May 5, 2025 13:30
48e71a5 to
325f721
Compare
xavfernandez
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Le mode opératoire pour reproduire le bug est dans la carte notion
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran