Skip to content

Candidature : Indiquer à l’employeur qui met en attente une candidature que son commentaire sera envoyé par mail au candidat et prescripteur. [GEN-2251] - #6085

Merged
dejafait merged 2 commits into
masterfrom
dejafait/improve_postpone_ui
May 7, 2025
Merged

Candidature : Indiquer à l’employeur qui met en attente une candidature que son commentaire sera envoyé par mail au candidat et prescripteur. [GEN-2251]#6085
dejafait merged 2 commits into
masterfrom
dejafait/improve_postpone_ui

Conversation

@dejafait

@dejafait dejafait commented May 5, 2025

Copy link
Copy Markdown
Contributor

🤔 Pourquoi ?

Pour être plus transparent.

💻 Captures d'écran

avant

image

après

capture 2025-05-06 à 15 00 55

@dejafait dejafait added the ajouté Ajouté dans le changelog. label May 5, 2025
@dejafait
dejafait requested a review from Copilot May 5, 2025 15:58
@dejafait dejafait self-assigned this May 5, 2025
@dejafait
dejafait force-pushed the dejafait/improve_postpone_ui branch from e2bdc3d to 36cd5be Compare May 5, 2025 15:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the candidate postponement page to notify the employer that both the candidature status change and the accompanying comment will be communicated by email to the candidate and prescriber. Additionally, it clarifies that the information can be viewed on the candidature details page.

  • Added descriptive informational text about email notifications.
  • Enhanced user guidance in the postponement process.
  • Introduced minor template comment, possibly as a placeholder.

@dejafait
dejafait force-pushed the dejafait/improve_postpone_ui branch from 36cd5be to 8fbfe69 Compare May 5, 2025 15:59
@gip-inclusion gip-inclusion deleted a comment from Copilot AI May 5, 2025
@dejafait
dejafait requested a review from Copilot May 5, 2025 16:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the candidature postponement page to inform the employer that both the status change and comment will be emailed to the candidate and their prescriber/orientation advisor.

  • Added informational messages in the HTML template.
  • Improved transparency by notifying the concerned parties about email communication.
Comments suppressed due to low confidence (1)

itou/templates/apply/process_postpone.html:22

  • [nitpick] The phrase 'prescripteur/orienteur' mixes two role names which might confuse the user. Consider standardizing this term if both refer to the same role or clarifying the distinction.
<p class="fs-sm">

@dejafait
dejafait requested a review from hellodeloo May 5, 2025 16:04

@hellodeloo hellodeloo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dejafait Comme le message ne concerne pas que le champ "Réponse" mais l'ensemble du "fonctionnement" de la mise en attente, je propose de mettre le texte dans la partie "Title" et de le mettre dans une alert-info, comme on le fait déjà dans de nombreux autres cas
capture 2025-05-06 à 15 00 55

En passant, c'etait aussi l'occasion de convertir le placeholder en help_text (pour l'a11y)

Je te laisse squasher les commits comme tu le veux

@dejafait
dejafait force-pushed the dejafait/improve_postpone_ui branch from 06a9d63 to a69dd4b Compare May 7, 2025 08:14
@dejafait
dejafait force-pushed the dejafait/improve_postpone_ui branch from a69dd4b to df90b7e Compare May 7, 2025 08:28
@dejafait

dejafait commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

@hellodeloo Merci pour tes fixes, j'ai squashé ce que je voulais et maintenant il me faut plus que ton tampon pour merger. 🙏

@hellodeloo
hellodeloo self-requested a review May 7, 2025 08:34
@dejafait
dejafait force-pushed the dejafait/improve_postpone_ui branch from df90b7e to ff4d71b Compare May 7, 2025 08:39
@dejafait
dejafait added this pull request to the merge queue May 7, 2025
Merged via the queue into master with commit 7c186fd May 7, 2025
@dejafait
dejafait deleted the dejafait/improve_postpone_ui branch May 7, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ajouté Ajouté dans le changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants