Connexion: Permettre de forcer la mise à jour du sub d'un compte SSO pour lequel l'email est associé à un autre sub. - #6146
Merged
Merged
Conversation
tonial
force-pushed
the
alaurent/sub_update
branch
from
May 16, 2025 11:47
ec04865 to
8b23736
Compare
EwenKorr
reviewed
May 16, 2025
tonial
force-pushed
the
alaurent/sub_update
branch
2 times, most recently
from
May 16, 2025 12:13
2b5742f to
e9bff54
Compare
EwenKorr
reviewed
May 16, 2025
EwenKorr
left a comment
EwenKorr
left a comment
Contributor
There was a problem hiding this comment.
LGTM mais ma connaissance limitée dans le mécanisme de SSO me pousse à laisser quelqu'un d'autre valider
tonial
force-pushed
the
alaurent/sub_update
branch
2 times, most recently
from
May 19, 2025 05:07
1e5f540 to
2a138a3
Compare
leo-naeka
reviewed
May 19, 2025
tonial
force-pushed
the
alaurent/sub_update
branch
2 times, most recently
from
May 19, 2025 09:52
b568e8a to
7a34ec3
Compare
tonial
force-pushed
the
alaurent/sub_update
branch
from
May 19, 2025 13:21
7a34ec3 to
35b3628
Compare
leo-naeka
approved these changes
May 19, 2025
leo-naeka
left a comment
leo-naeka
left a comment
Contributor
There was a problem hiding this comment.
Te laisse trancher sur la dernière remarque :)
Comment on lines
+512
to
+513
| assert fieldsets[-1][1]["fields"][11] == "identity_provider" | ||
| fieldsets[-1][1]["fields"].insert(12, "allow_next_sso_sub_update") |
Contributor
There was a problem hiding this comment.
nit: les assert sur les groupes vont bien comme ça, mais pour simplifier la gestion dans le temps, que penses-tu de simplement récupérer la position d'identity_providerpour insérer le champ ?
Suggested change
| assert fieldsets[-1][1]["fields"][11] == "identity_provider" | |
| fieldsets[-1][1]["fields"].insert(12, "allow_next_sso_sub_update") | |
| identity_provider_index = fieldsets[-1][1]["fields"].index("identity_provider") | |
| fieldsets[-1][1]["fields"].insert(identity_provider_index + 1, "allow_next_sso_sub_update") |
tonial
force-pushed
the
alaurent/sub_update
branch
from
May 19, 2025 14:26
35b3628 to
5ad7736
Compare
Sometimes, a SSO returns us the same email with a different sub (maybe they store case sensitive emails , of the old account was deleted and the user created a new one). Allow the support team to fix the issue for a given user.
tonial
force-pushed
the
alaurent/sub_update
branch
from
May 19, 2025 19:04
5ad7736 to
70ee94c
Compare
tonial
added this pull request to the merge queue
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Parfois un utilisateur se connecte avec France Connect ou PE Connect et on voit arriver un email connu (également associé au même SSO) mais avec un sub différent.
Peut être qu'ils distinguent les emails sur la case, autorisant un compte
test@gmail.cometTEST@gmail.com. Peut être que l'ancien compte a été supprimé ou a changé d'email puis un nouveau compte a été créé avec l'email.En tout cas, on est bloqué, et on voudrait permettre à l'utilisateur dont on a vérifié l'identité (pour s'assurer que ce n'est pas un compte partagé) de se connecter sans devoir faire plusieurs actions en ligne de commande.
J'ajoute donc un bouton dans l'admin pour permettre la mise à jour du sub à la prochaine connexion.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran