Skip to content

Éligibilité : Correction de durées de certification de critères administratifs incorrects - #6173

Merged
francoisfreitag merged 1 commit into
masterfrom
ff/fix-crits
May 21, 2025
Merged

francoisfreitag merged 1 commit into
masterfrom
ff/fix-crits

Conversation

@francoisfreitag

@francoisfreitag francoisfreitag commented May 21, 2025 •

Copy link
Copy Markdown
Member

🤔 Pourquoi ?

Il y a des données invalides dans la base de données.

SELECT certified_at
FROM eligibility_selectedadministrativecriteria
WHERE certified AND certification_period IS NULL
ORDER BY 1 DESC;

donne 1048 resultats, le plus récent date du 9 janvier 2025.

https://inclusion.sentry.io/issues/42627599/?project=4508410589020240&referrer=github-pr-bot

There is bad data in the database, probably due to an earlier bug of the
API particulier integration.

```
SELECT certified_at
FROM eligibility_selectedadministrativecriteria
WHERE certified AND certification_period IS NULL
ORDER BY 1 DESC;
```

Reveals 1048 results, the latest on January 9th, 2025.
@francoisfreitag francoisfreitag added the modifié Modifié dans le changelog. label May 21, 2025
@francoisfreitag francoisfreitag self-assigned this May 21, 2025
@francoisfreitag francoisfreitag added the modifié Modifié dans le changelog. label May 21, 2025
@francoisfreitag
francoisfreitag enabled auto-merge May 21, 2025 07:37
@francoisfreitag
francoisfreitag added this pull request to the merge queue May 21, 2025
Merged via the queue into master with commit fa9035b May 21, 2025
@francoisfreitag
francoisfreitag deleted the ff/fix-crits branch May 21, 2025 07:47
crit.certified_at, crit.certified_at + datetime.timedelta(days=92)
)
geiq.append(crit)
GEIQSelectedAdministrativeCriteria.objects.bulk_update(iae, fields=["certification_period"])

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Un diag geiq a été modifié par erreur. Je corrige.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ou plusieurs diags :'(

@francoisfreitag francoisfreitag May 21, 2025 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ou aucun 🍀, la requête suivante ne retourne aucun résultat sur une base qui contient bien les 1048 critères corrompus.

SELECT *
FROM eligibility_geiqselectedadministrativecriteria
WHERE id in (
     SELECT id
     FROM eligibility_selectedadministrativecriteria
     WHERE certified AND certification_period IS NULL
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modifié Modifié dans le changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants