Skip to content

Éligibilité : Créer un nouveau diagnostic plutôt que modifier la date de fin lors de la mise à jour - #6177

Merged
rsebille merged 1 commit into
masterfrom
rsebille/stop-diagnosis-extension
May 22, 2025
Merged

Éligibilité : Créer un nouveau diagnostic plutôt que modifier la date de fin lors de la mise à jour#6177
rsebille merged 1 commit into
masterfrom
rsebille/stop-diagnosis-extension

Conversation

@rsebille

Copy link
Copy Markdown
Contributor

🤔 Pourquoi ?

Changement de comportement suite à un point avec le métier : #6090 (comment)

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?
  • Ajouter l'étiquette « Bug » ?

@francoisfreitag francoisfreitag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autrement 👍

Comment thread itou/eligibility/models/iae.py Outdated
return eligibility_diagnosis

# Otherwise, we create a new one...
# Create a new one...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mieux vaudrait expliquer pourquoi (aligner avec les durées de certification des critères des diags employeurs)

@rsebille
rsebille force-pushed the rsebille/stop-diagnosis-extension branch from a01f996 to cf8ba1d Compare May 22, 2025 07:11
Comment thread itou/eligibility/models/iae.py Outdated
return eligibility_diagnosis

# Otherwise, we create a new one...
# Create a new diagnostic to be aligned with the criteria certification period

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Create a new diagnostic to be aligned with the criteria certification period
# Create a new diagnostic to be aligned with the criteria certification period.

This is so the validity period of a diagnosis is aligned with the
validity period of the possible certified criteria.
@rsebille
rsebille force-pushed the rsebille/stop-diagnosis-extension branch from cf8ba1d to 8fd51c2 Compare May 22, 2025 09:59
@rsebille
rsebille added this pull request to the merge queue May 22, 2025
Merged via the queue into master with commit 128cfb9 May 22, 2025
@rsebille
rsebille deleted the rsebille/stop-diagnosis-extension branch May 22, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modifié Modifié dans le changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants