Skip to content

Candidature : mettre à jour l'emetteur de la candidature d'un candidat lors de son transfert - #6185

Merged
vincentporte merged 3 commits into
masterfrom
vp/GEN-2482_prevent_sender_being_different_from_job_seeker
May 27, 2025
Merged

Candidature : mettre à jour l'emetteur de la candidature d'un candidat lors de son transfert#6185
vincentporte merged 3 commits into
masterfrom
vp/GEN-2482_prevent_sender_being_different_from_job_seeker

Conversation

@vincentporte

@vincentporte vincentporte commented May 22, 2025

Copy link
Copy Markdown

🤔 Pourquoi ?

Eviter les cas de candidature émise par un candidat avec un autre candidat en tant qu'émetteur.

Non sens fonctionnel, complexifiant la notification et l'archivage des candidats sans activité depuis plus de 2 ans.

🍰 Comment ?

  • mise à jour des données via une migration spécifique
  • ajout du champ dans la liste des champs à transférer lors du transfert de candidature dans l'admin
  • ajout d'une contrainte sur le modèle JobApplication

todo :

  • tester la contrainte

🚨 À vérifier

NON Mettre à jour le CHANGELOG_breaking_changes.md ?
NON Ajouter l'étiquette « Bug » ?

@vincentporte vincentporte self-assigned this May 22, 2025
@vincentporte vincentporte added the modifié Modifié dans le changelog. label May 22, 2025
@notion-workspace

Copy link
Copy Markdown

@vincentporte
vincentporte marked this pull request as draft May 22, 2025 17:05
@vincentporte
vincentporte force-pushed the vp/GEN-2482_prevent_sender_being_different_from_job_seeker branch 2 times, most recently from 494cd4f to 3e55a39 Compare May 26, 2025 09:38
@vincentporte
vincentporte marked this pull request as ready for review May 26, 2025 09:38
@vincentporte
vincentporte force-pushed the vp/GEN-2482_prevent_sender_being_different_from_job_seeker branch from 3e55a39 to e55be8e Compare May 26, 2025 09:39
Comment thread itou/users/admin.py Outdated
@vincentporte
vincentporte force-pushed the vp/GEN-2482_prevent_sender_being_different_from_job_seeker branch from e55be8e to 7b8e4ea Compare May 26, 2025 13:54
@vincentporte
vincentporte requested a review from xavfernandez May 26, 2025 13:55
Comment thread itou/users/admin.py Outdated
Comment thread itou/users/admin.py Outdated
Comment thread tests/job_applications/tests.py Outdated
@vincentporte
vincentporte force-pushed the vp/GEN-2482_prevent_sender_being_different_from_job_seeker branch from 7b8e4ea to af1a51c Compare May 27, 2025 14:43
@vincentporte
vincentporte requested a review from xavfernandez May 27, 2025 14:43
Comment thread itou/users/admin.py Outdated
Comment thread tests/users/test_admin.py Outdated
vincent porte added 3 commits May 27, 2025 17:01
remove case when sender is an other job_seeker than the real one. Appeared during job_application transfers, which has to be fixed
do not allow an other job_seeker as sender, when job_application is sent by job_seeker
@vincentporte
vincentporte force-pushed the vp/GEN-2482_prevent_sender_being_different_from_job_seeker branch from af1a51c to 41412e0 Compare May 27, 2025 15:02
@vincentporte
vincentporte added this pull request to the merge queue May 27, 2025
Merged via the queue into master with commit 3f33af6 May 27, 2025
@vincentporte
vincentporte deleted the vp/GEN-2482_prevent_sender_being_different_from_job_seeker branch May 27, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modifié Modifié dans le changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants