Vie privée : permettre la désactivation du traitement d'archivage en cas de données incohérentes - #6220
Merged
Merged
Conversation
tonial
requested changes
May 29, 2025
|
|
||
|
|
||
| class TestNotifyArchiveUsersManagementCommand: | ||
| @pytest.mark.parametrize("suspended", [True, False, None, "true"]) |
Contributor
There was a problem hiding this comment.
Je ne comprends pas trop le choix des valeurs de ce parametrize : c'est la valeur du setting que tu modifies, pas celle de la variable d'environnement.
C'est donc nécessairement un booléen
vincentporte
force-pushed
the
vp/GEN-2497_suspend_with_env_var
branch
from
June 2, 2025 07:15
a22b4c1 to
fc4eb02
Compare
tonial
reviewed
Jun 3, 2025
tonial
approved these changes
Jun 3, 2025
added 2 commits
June 3, 2025 13:45
Allow the command to be suspended using environment variables when a failure occurs, to avoid errors being sent every 5 minutes to sentry while waiting for data to be corrected
This reverts commit 6e18b51.
vincentporte
force-pushed
the
vp/GEN-2497_suspend_with_env_var
branch
from
June 3, 2025 11:47
fc4eb02 to
b9bc10a
Compare
vincentporte
added this pull request to the merge queue
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
La commande notify_archive_users échoue lorsqu'une relation entre User et un autre modèle existe à tord pour un job_seeker
🍰 Comment ?