Vie privée : ajout de contrôle de cohérence sur le déclarant d'une prolongation ou d'une demande de prolongation#6221
Merged
Conversation
tonial
approved these changes
Jun 2, 2025
xavfernandez
reviewed
Jun 2, 2025
| raise ValidationError("L'adresse email et le numéro de téléphone ne peuvent être saisis pour ce motif") | ||
|
|
||
| # declared_by and declared_by_siae coherence | ||
| if not self.declared_by_siae.members.filter(pk=self.declared_by.pk).exists(): |
Contributor
There was a problem hiding this comment.
nit: cela peut être embêtant pour le formulaire de modification dans l'admin si un CompanyMembership a été supprimé entre temps. Depuis quelques mois on ne supprime normalement plus les memberships pour juste les désactiver mais il faut avoir cela en tête :)
vincentporte
force-pushed
the
vp/GEN-2501_admin_integrity_check
branch
from
0f5616a to
33ac974
Compare
vincentporte
force-pushed
the
vp/GEN-2501_admin_integrity_check
branch
from
33ac974 to
87eb472
Compare
vincentporte
force-pushed
the
vp/GEN-2501_admin_integrity_check
branch
from
87eb472 to
b463353
Compare
vincentporte
force-pushed
the
vp/GEN-2501_admin_integrity_check
branch
from
b463353 to
4b94fc4
Compare
Add a test on saving, to check if declared_by user is member of declared_by_siae and prevent CommonProlongation declared_by job_seeker TESTS IN PROGRESS
vincentporte
force-pushed
the
vp/GEN-2501_admin_integrity_check
branch
from
4b94fc4 to
b07242c
Compare
francoisfreitag
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Eviter les
ProlongationouProlongationRequestdont ledeclared_byest unjob_seekercorrection des cas existants par #6228
🍰 Comment ?
cohérence des données necessaire au traitement d'archivage des utilisateurs
🚨 À vérifier
NON] Mettre à jour le CHANGELOG_breaking_changes.md ?
NON Ajouter l'étiquette « Bug » ?
💻 Captures d'écran