Contrôle a posteriori : Correction d’une régression dans la validation du formulaire de sélection des critères administratifs [GEN-2457]#6238
Merged
Conversation
Regression introduced in 9acbe5f. The user attribute has been replaced with a `is_authorized_prescriber`. Passing a user (Python object), which `__bool__()` is always True, resulted in the form validation acting as-if an authorized prescriber was submitting the data, thus not validating eligibility. However, an employer is acting.
francoisfreitag
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Le formulaire autorisait la saisie d’un seul critère de niveau 2 pour justifier une auto-prescription, alors que deux ou trois critères sont requis (selon le type de SIAE).
🍰 Comment ?
Bisecté à 9acbe5f.
Voir le message de commit pour l’explication et pourquoi le code s’exécutait sans erreur.
🏝️ Comment tester ?
make resetdbAttendu : une erreur, il faut trois critères de niveau 2 pour une ETTI.
Constaté : le formulaire est accepté, l’employeur peut justifier uniquement un critère
💻 Captures d'écran