Repository navigation
Vie privée : distinguer les candidatures archivées des candidatures et utilisateurs anonymisés [GEN-2512] - #6255
Merged
Merged
Conversation
tonial
reviewed
Jun 3, 2025
tonial
left a comment
tonial
left a comment
Contributor
There was a problem hiding this comment.
Vu que tu peux mettre en pause l'anonymisation des données, est-ce que tu ne peux pas aussi renommer les modèles au passage ?
vincentporte
force-pushed
the
vp/desambiguate_archive
branch
2 times, most recently
from
June 3, 2025 14:39
501286b to
b9657f1
Compare
vincentporte
changed the title
tonial
approved these changes
Jun 5, 2025
tonial
left a comment
tonial
left a comment
Contributor
There was a problem hiding this comment.
J'ai l'impression que la migration 5 et la 6 pourraient être une seule migration
vincentporte
force-pushed
the
vp/desambiguate_archive
branch
from
June 5, 2025 08:22
b9657f1 to
4c56f5e
Compare
added 3 commits
June 5, 2025 11:26
Use Anonymized as prefix instead of Archived in models name
archived_at already exists in JobApplication model which could be confusing. Anonymised application is deleted from JobApplication. But archived application is just a new state in JobApplication
Reduce ambiguity between the Archive app, its archive_jobseeker and archive_job_applications (etc ...) and job_applications with an archived state. The former are anonymous, not accessible to users. The latter are hidden in dedicated views.
vincentporte
force-pushed
the
vp/desambiguate_archive
branch
from
June 5, 2025 09:26
4c56f5e to
9c0f9c8
Compare
vincentporte
added this pull request to the merge queue
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Réduire l'ambiguité
🍰 Comment ?
ArchivedXenAnonymizedXarchived_atenanonymized_atverbose name, ajout des méthodes__str__sur les modèles🚀 Déploiement
🔴 avant de fusionner cette PR, mettre en pause la commande
notify_archive_users🔴🔴 ajouter
SUSPEND_NOTIFY_ARCHIVE_USERS=Truedans les variables d'env 🔴