Fiches Salarié : Ne plus proposer l'option "Renvoyer" si des informations sont manquantes ou erronées - #6322
Merged
Merged
Conversation
rsebille
force-pushed
the
rsebille/er-missing-birthcountry
branch
from
June 12, 2025 10:09
e13d116 to
5b2cc4b
Compare
EwenKorr
changed the title
EwenKorr
approved these changes
Jun 12, 2025
| def has_valid_data_filled(self): | ||
| # In `JobSeekerProfile.clean_model()` some fields are only checked if present, but we need them to be filled | ||
| try: | ||
| has_extra_required_fields = all( |
Contributor
There was a problem hiding this comment.
Est-ce qu'on ne voudrait pas intégrer ces vérifications à EmployeeRecord._clean_job_seeker directement ?
Contributor
Author
There was a problem hiding this comment.
J'ai pas trop osé toucher à ces fonctions n'étant pas serein sur les conséquences et sentant que j'allais me retrouver avec une pelote de laine, car il y a sûrement mieux à faire que ces fonctions 🤷.
hellodeloo
approved these changes
Jun 12, 2025
xavfernandez
approved these changes
Jun 12, 2025
rsebille
force-pushed
the
rsebille/er-missing-birthcountry
branch
from
June 12, 2025 13:49
a9e9440 to
dce6edb
Compare
rsebille
added this pull request to the merge queue
Jun 12, 2025
xavfernandez
removed this pull request from the merge queue due to a manual request
Jun 12, 2025
rsebille
force-pushed
the
rsebille/er-missing-birthcountry
branch
from
June 12, 2025 14:48
dce6edb to
baab9c2
Compare
rsebille
enabled auto-merge
June 12, 2025 14:55
rsebille
added this pull request to the merge queue
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Dans certain cas, le pays (et ville) de naissance sont supprimées après la première intégration, donc lorsque que l'employeur fait "Renvoyer" (sans modification) ça explose dans
transfer_employee_recordà cause du champ manquant.On vérifie donc désormais que toutes les données sont bien renseignées avant de proposer l'option "Renvoyer", si ce n'est pas le cas on laisse seulement "Modifier et renvoyer".
🏝️ Comment tester ?
💻 Captures d'écran