Skip to content

Candidature : ajouter un contrôle de cohérence sur le type de l'emetteur - #6360

Merged
vincentporte merged 4 commits into
masterfrom
vp/GEN-2545_incoherent_jobapplication_sender_kind
Jul 1, 2025
Merged

Candidature : ajouter un contrôle de cohérence sur le type de l'emetteur#6360
vincentporte merged 4 commits into
masterfrom
vp/GEN-2545_incoherent_jobapplication_sender_kind

Conversation

@vincentporte

@vincentporte vincentporte commented Jun 16, 2025

Copy link
Copy Markdown

🤔 Pourquoi ?

Approx 651 candidatures ont des types d'emetteur incohérents, ce que nous ne désirons pas.

JobApplication.objects.filter(sender__isnull=False).exclude(sender_kind=F('sender__kind')).values('sender_kind').annotate(count=Count('id')).order_by('sender_kind')
{'sender_kind': 'employer', 'count': 443}
{'sender_kind': 'prescriber', 'count': 208}

🍰 Comment ?

  1. harmoniser les longueurs des champs user.kind et job_application.sender_kind : suppression de la longueur max
  2. supprimer la valeur par défault prescriber sur JobApplication.sender_kind
  3. ajouter les contrôles de cohérence sur le modèle et dans le formulaire de l'admin

@notion-workspace

Copy link
Copy Markdown

@vincentporte vincentporte changed the title Candidature : ajouter un contrôle de cohérence sur le type de l'e Candidature : ajouter un contrôle de cohérence sur le type de l'emetteur Jun 16, 2025
@vincentporte vincentporte self-assigned this Jun 16, 2025
@vincentporte vincentporte added the ajouté Ajouté dans le changelog. label Jun 16, 2025
@vincentporte
vincentporte requested a review from tonial June 16, 2025 15:21
@vincentporte
vincentporte force-pushed the vp/GEN-2545_incoherent_jobapplication_sender_kind branch from 356e972 to 28b6271 Compare June 16, 2025 16:25
Comment thread itou/job_applications/migrations/0019_sync_sender_kind.py Outdated
Comment thread tests/job_applications/tests.py Outdated
@vincentporte
vincentporte force-pushed the vp/GEN-2545_incoherent_jobapplication_sender_kind branch from 28b6271 to 438a7cd Compare June 17, 2025 13:43
@vincentporte
vincentporte requested a review from tonial June 17, 2025 13:43
@vincentporte
vincentporte force-pushed the vp/GEN-2545_incoherent_jobapplication_sender_kind branch from 438a7cd to f6ca246 Compare June 18, 2025 06:22
@vincentporte
vincentporte force-pushed the vp/GEN-2545_incoherent_jobapplication_sender_kind branch from f6ca246 to 25be396 Compare July 1, 2025 09:25
@vincentporte
vincentporte force-pushed the vp/GEN-2545_incoherent_jobapplication_sender_kind branch from 25be396 to f8e592f Compare July 1, 2025 09:26
Comment thread itou/job_applications/migrations/0020_alter_and_sync_sender_kind.py
vincent porte added 4 commits July 1, 2025 14:22
@vincentporte
vincentporte force-pushed the vp/GEN-2545_incoherent_jobapplication_sender_kind branch from f8e592f to 49e8e2f Compare July 1, 2025 12:23
@vincentporte
vincentporte enabled auto-merge July 1, 2025 12:28
@vincentporte
vincentporte added this pull request to the merge queue Jul 1, 2025
Merged via the queue into master with commit 0565590 Jul 1, 2025
@vincentporte
vincentporte deleted the vp/GEN-2545_incoherent_jobapplication_sender_kind branch July 1, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ajouté Ajouté dans le changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants