Candidatures: Modification du fonctionnement de la barre d’action traitement par lot [GEN-2451] by tonial · Pull Request #6384 · gip-inclusion/les-emplois

tonial · 2025-06-20T10:02:11Z

🤔 Pourquoi ?

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

Mettre à jour le CHANGELOG_breaking_changes.md ?
Ajouter l'étiquette « Bug » ?

🏝️ Comment tester ?

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

Avant:

Après:

notion-workspace · 2025-06-20T10:02:16Z

🏎️ [1/3 Traitement par lot] Modification du fonctionnement de la barre d’action traitement par lot

github-actions · 2025-06-20T10:08:09Z

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

tonial · 2025-06-23T09:16:03Z

@hellodeloo Si tu veux bien jeter un oeil sur le html : dans la maquette j'ai l'impression que les bouton sont en btn-sm, mais aussi que la barre elle même a des marge plus faible.
Et le bouton du dropdown est trop large, sans que je comprenne pourquoi il prend autant de place.

hellodeloo

LGTM

xavfernandez

Je me dis que ça allégerait pas mal la PR de sortir tous les correctifs de mes typos de copier coller :)

xavfernandez · 2025-07-03T06:53:53Z

        response = HttpResponse()
        response["HX-Refresh"] = "true"
        return response
+    transfer_form = JobApplicationInternalTransferForm(request, job_app_count=selected_nb)


nit: vu que postpone_form est directement défini dans le context, j'aurais également inline le transfer_form

xavfernandez · 2025-07-03T09:20:58Z

    # of any template using this templatetag

+    class_kwargs = (
+        "btn btn-lg btn-link-white btn-block btn-ico justify-content-cente"


justify-content-center

xavfernandez · 2025-07-03T09:25:50Z

+        # No modal & linked button
+        assert get_process_modal() is None
+        postpone_button = get_process_button()
+        assert pretty_indented(postpone_button) == snapshot(name="inactive process button")


Les fichiers de snapshots ne sont pas dans le commit 😱

et les tests passent malgré tout 🤔

oui, ils sont juste dans le mauvais commit 😅 (celui d'accept je crois)

Ah, ils sont dans un commit d'avant !
Je corrige

We need to remove the dropdown since the transfer button will soon be in a dropdown instead

It's better to have all messages of the same page as toast, and it will allow us to display them when returing to the list view after a "batch" accept

tonial requested a review from hellodeloo June 20, 2025 10:02

tonial self-assigned this Jun 20, 2025

tonial added 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC modifié Modifié dans le changelog. labels Jun 20, 2025

tonial force-pushed the alaurent/boost_job_app_transfer branch 2 times, most recently from 96f04d6 to 3f7797b Compare June 20, 2025 12:41

hellodeloo reviewed Jun 20, 2025

View reviewed changes

Comment thread itou/templates/apply/includes/siae_actions.html Outdated

Comment thread itou/templates/apply/includes/siae_actions_modals.html Outdated

Comment thread itou/templates/apply/includes/siae_actions_modals.html Outdated

tonial force-pushed the alaurent/boost_job_app_transfer branch 2 times, most recently from a6a1349 to 3e87419 Compare June 23, 2025 09:02

tonial requested a review from xavfernandez June 23, 2025 09:04

tonial marked this pull request as ready for review June 23, 2025 09:04

hellodeloo approved these changes Jun 23, 2025

View reviewed changes

tonial force-pushed the alaurent/boost_job_app_transfer branch 2 times, most recently from 4e4a4c5 to 83dfe19 Compare June 24, 2025 07:57

xavfernandez reviewed Jun 24, 2025

View reviewed changes

tonial force-pushed the alaurent/boost_job_app_transfer branch 2 times, most recently from d5d4f53 to 201680e Compare June 24, 2025 12:56

xavfernandez reviewed Jun 24, 2025

View reviewed changes

Comment thread tests/www/apply/test_batch_views.py Outdated

tonial changed the base branch from master to alaurent/batch_typos June 24, 2025 19:05

tonial mentioned this pull request Jun 24, 2025

Candidature: Permettre les mêmes actions sur une nouvelle candidature que sur une candidature à l'étude [GEN-2389] #6401

Merged

2 tasks

tonial force-pushed the alaurent/batch_typos branch from 69ec056 to 9ee4405 Compare June 24, 2025 19:36

tonial force-pushed the alaurent/boost_job_app_transfer branch from 201680e to 75d193a Compare June 24, 2025 19:36

Base automatically changed from alaurent/batch_typos to master June 25, 2025 04:55

tonial force-pushed the alaurent/boost_job_app_transfer branch 2 times, most recently from 2fdced2 to e13f69e Compare June 25, 2025 13:21

tonial mentioned this pull request Jun 26, 2025

Tech: Utilisation d'un template tag pour le bouton accepter du détail des candidatures #6421

Merged

2 tasks

tonial force-pushed the alaurent/boost_job_app_transfer branch from e13f69e to 0eaf85d Compare June 26, 2025 19:33

tonial force-pushed the alaurent/boost_job_app_transfer branch 5 times, most recently from 2dab668 to 7f1d7fb Compare June 28, 2025 04:14

tonial changed the base branch from master to alaurent/apply_accept_button June 29, 2025 03:57

Base automatically changed from alaurent/apply_accept_button to master June 30, 2025 08:15

tonial force-pushed the alaurent/boost_job_app_transfer branch from 7f1d7fb to 43dfe28 Compare June 30, 2025 08:21

tonial requested review from francoisfreitag and xavfernandez June 30, 2025 09:43

tonial force-pushed the alaurent/boost_job_app_transfer branch from 43dfe28 to db35d53 Compare July 3, 2025 05:15

xavfernandez reviewed Jul 3, 2025

View reviewed changes

xavfernandez approved these changes Jul 3, 2025

View reviewed changes

tonial added 8 commits July 3, 2025 11:32

apply: Improve get_transfer_button helper

62932e7

apply: Change job application batch transfer button

18d2799

We need to remove the dropdown since the transfer button will soon be in a dropdown instead

apply: Allow accept view to take a next_url as query parameter

e0fc3fa

apply: Allow eligibility view to take a next_url as query parameter

20af52a

apply: Refactor job application batch actions banner

ef89d37

apply: Add batch process view

1571208

apply: Add process to siae batch actions

1fec678

apply: Change accept view messages to toast

65b8cf5

It's better to have all messages of the same page as toast, and it will allow us to display them when returing to the list view after a "batch" accept

tonial force-pushed the alaurent/boost_job_app_transfer branch from db35d53 to 65b8cf5 Compare July 3, 2025 09:40

tonial enabled auto-merge July 3, 2025 09:40

tonial added this pull request to the merge queue Jul 3, 2025

Merged via the queue into master with commit b742990 Jul 3, 2025

tonial deleted the alaurent/boost_job_app_transfer branch July 3, 2025 10:00

Conversation

tonial commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 Pourquoi ?

🍰 Comment ?

🚨 À vérifier

🏝️ Comment tester ?

💻 Captures d'écran

Uh oh!

notion-workspace Bot commented Jun 20, 2025

Uh oh!

github-actions Bot commented Jun 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tonial commented Jun 23, 2025

Uh oh!

hellodeloo left a comment

Choose a reason for hiding this comment

Uh oh!

xavfernandez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xavfernandez Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

xavfernandez Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

xavfernandez Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

tonial Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

xavfernandez Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

tonial Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tonial commented Jun 20, 2025 •

edited

Loading