Admin : permettre la modification de la date de début des suspensions si la nouvelle date est avant la date de création - #6388
Merged
Conversation
celine-m-s
force-pushed
the
celinems/update-suspension
branch
2 times, most recently
from
June 20, 2025 21:24
b029a60 to
69b125a
Compare
celine-m-s
force-pushed
the
celinems/update-suspension
branch
from
June 25, 2025 15:21
69b125a to
ba190f8
Compare
celine-m-s
marked this pull request as ready for review
June 25, 2025 15:30
celine-m-s
force-pushed
the
celinems/update-suspension
branch
from
June 25, 2025 15:30
ba190f8 to
13905ec
Compare
celine-m-s
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
tonial
approved these changes
Jun 30, 2025
In 2021, we introduced a different behaviour in the Django admin but without testing it: only end users could change suspension's start date in the past. Admin users were not allowed to start a suspension before its creation date. Years went by and admin users forgot this was intended to be this way. They were just blocked. This commit deletes this rule and adds a test for retrocompatibility purposes.
celine-m-s
force-pushed
the
celinems/update-suspension
branch
from
July 4, 2025 08:51
13905ec to
a6e7cd7
Compare
celine-m-s
added this pull request to the merge queue
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Le support est bloqué car des utilisateurs demandent à changer la date de début des suspensions. Actuellement, la limite est fixée à la date de création de la suspension pour le support seulement. Les utilisateurs finaux peuvent faire commencer la suspension jusqu'à 365 jours avant sa date de création (
Suspension.MAX_RETROACTIVITY_DURATION_DAYS).Ce comportement a été introduit dans cette PR.
Aujourd'hui, le support a oublié que c'était une demande métier et se retrouve simplement coincé. Il crée des tickets Supportix. Sandrine et Zohra pensent que le plus simple et que tout le monde suive la même règle.
Cette PR est liée à la PR #6243 . Le support a mis à jour manuellement la date de fin des PASS IAE mais ne peut pas répercuter les modifications sur les suspensions. Passer par un script n'est pas non plus la solution car il y a plusieurs cas d'exception. Leur laisser la main est le plus efficace.
🍰 Comment ?
Suppression de la règle et ajout d'un test.
🚨 À vérifier
🏝️ Comment tester ?
Modifier une suspension selon les cas suivants :