Candidature: Permettre les mêmes actions sur une nouvelle candidature que sur une candidature à l'étude [GEN-2389] - #6401
Merged
Conversation
tonial
force-pushed
the
alaurent/boost_siae_batch_actions
branch
from
June 24, 2025 05:09
96bf6a8 to
5878498
Compare
tonial
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
tonial
force-pushed
the
alaurent/boost_job_app_transfer
branch
from
June 24, 2025 07:57
4e4a4c5 to
83dfe19
Compare
tonial
force-pushed
the
alaurent/boost_siae_batch_actions
branch
from
June 24, 2025 07:57
5878498 to
85bc015
Compare
francoisfreitag
left a comment
francoisfreitag
left a comment
Member
There was a problem hiding this comment.
STR:
- EI
- Créer une candidature pour un nouveau candidat.
- Dans la liste des candidatures, sélectionner la candidature du nouveau candidat
- Accepter via les batchs actions
- L’utilisateur est redirigé sur http://localhost:8000/apply/siae/list?states=new&states=processing, sans message ou explication.
| simulate_applications_selection([acceptable_app.pk]) | ||
| accept_button = get_accept_button() | ||
| assert accept_button is not None | ||
| assert pretty_indented(accept_button) == snapshot(name="active accept button") |
Member
There was a problem hiding this comment.
On n’a pas trois snapshots avec exactement le même nom ?
Contributor
Author
There was a problem hiding this comment.
Si, ça vérifie qu'à chaque fois on a le même résultat (le bouton est actif) sans avoir 3 snapshots identiques avec des noms ou numéros différents
tonial
force-pushed
the
alaurent/boost_job_app_transfer
branch
from
June 24, 2025 12:53
83dfe19 to
d5d4f53
Compare
tonial
force-pushed
the
alaurent/boost_siae_batch_actions
branch
2 times, most recently
from
June 24, 2025 12:56
d5f94f4 to
5e57628
Compare
tonial
force-pushed
the
alaurent/boost_job_app_transfer
branch
from
June 24, 2025 12:56
d5d4f53 to
201680e
Compare
Contributor
Author
|
Damn... il manque un diag sur la candidature, mais le message d'erreur ne s'affiche pas 🤔
|
tonial
force-pushed
the
alaurent/boost_siae_batch_actions
branch
from
June 24, 2025 19:36
5e57628 to
fdc551b
Compare
tonial
force-pushed
the
alaurent/boost_job_app_transfer
branch
2 times, most recently
from
June 25, 2025 13:03
75d193a to
2fdced2
Compare
tonial
force-pushed
the
alaurent/boost_siae_batch_actions
branch
2 times, most recently
from
June 25, 2025 13:21
09fd283 to
dfa173f
Compare
tonial
force-pushed
the
alaurent/boost_job_app_transfer
branch
2 times, most recently
from
June 26, 2025 19:33
e13f69e to
0eaf85d
Compare
tonial
force-pushed
the
alaurent/boost_siae_batch_actions
branch
2 times, most recently
from
June 26, 2025 19:34
da9f610 to
53e5aed
Compare
tonial
force-pushed
the
alaurent/boost_job_app_transfer
branch
2 times, most recently
from
June 27, 2025 05:05
651f6e5 to
99a943d
Compare
tonial
force-pushed
the
alaurent/boost_siae_batch_actions
branch
2 times, most recently
from
June 27, 2025 09:16
e5b70d7 to
fa3a737
Compare
tonial
force-pushed
the
alaurent/boost_job_app_transfer
branch
from
June 27, 2025 09:16
99a943d to
ce41f20
Compare
tonial
force-pushed
the
alaurent/boost_job_app_transfer
branch
from
July 3, 2025 09:40
db35d53 to
65b8cf5
Compare
tonial
force-pushed
the
alaurent/boost_siae_batch_actions
branch
3 times, most recently
from
July 7, 2025 11:17
dec08cc to
6cdaee3
Compare
tonial
force-pushed
the
alaurent/boost_siae_batch_actions
branch
4 times, most recently
from
July 8, 2025 12:50
1345c67 to
d46cb9a
Compare
leo-naeka
approved these changes
Jul 9, 2025
leo-naeka
left a comment
leo-naeka
left a comment
Contributor
There was a problem hiding this comment.
LGTM sur le périmètre de la PR
Par contre je suis tombé sur quelques coquilles en testant (mais présentes depuis plusieurs semaines, genre sur la vue tableau : tu sélectionnes une candidature acceptée, le tooltip de l'action "Accepter" n'est pas adapté). À en rediscuter.
Merci en tout cas pour le découpage, bien plus aisé pour la relecture 🙏
Contributor
Author
|
Merci pour la relecture |
tonial
force-pushed
the
alaurent/boost_siae_batch_actions
branch
from
July 10, 2025 05:05
d46cb9a to
768e2ed
Compare
tonial
enabled auto-merge
July 10, 2025 05:06
tonial
force-pushed
the
alaurent/boost_siae_batch_actions
branch
from
July 10, 2025 07:58
768e2ed to
4eb2ac7
Compare
tonial
added this pull request to the merge queue
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour tester, se connecter en tant qu'employeur et aller
Dans les 2 cas, les actions sont les mêmes, avec la transition vers le statut à l'étude en plus pour une candidature nouvelle.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran