Fiches salarié : Retrait d’une vérification de cohérence de l’adresse - #6407
Merged
Conversation
xavfernandez
approved these changes
Jun 24, 2025
xavfernandez
approved these changes
Jun 24, 2025
…_updated_by_user Can use the test_data directly.
Added assertions to confirm the reason for the 200 status code (form errors). Previously, the test data was mutated in place to be invalid and the mutation would remain until the end of the test.
The assertion is covered on line 468: data["hexa_lane_number"] = "a", and is not grouped with the rest of the hexa_lane_number tests. Rather than moving it, simply delete it.
The consistency check is flaky, a support ticket came in for a job seeker living in Bastia (post code is 20600, INSEE code is 2B033). The employer cannot enter the user address. Following @rsebille suggestion, validate the post code against the cities instead. https://fr.wikipedia.org/wiki/Liste_des_communes_de_France_dont_le_code_postal_ne_correspond_pas_au_d%C3%A9partement
francoisfreitag
enabled auto-merge
June 24, 2025 15:19
francoisfreitag
added this pull request to the merge queue
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Un employeur est bloqué par cette vérification pour remplir l’adresse de son salarié dans sa fiche salarié. Le salarié habite à Bastia, dont le code postal est 20600, et le code INSEE 2B033.
https://fr.wikipedia.org/wiki/Liste_des_communes_de_France_dont_le_code_postal_ne_correspond_pas_au_d%C3%A9partement
🍰 Comment ?
Remplacé par une vérification que le code postal correspond à une ville.