Skip to content

Add auto refused applications to metabase table - #6485

Merged
tonial merged 2 commits into
masterfrom
laurinehu/add_archived_flag
Jul 17, 2025
Merged

tonial merged 2 commits into
masterfrom
laurinehu/add_archived_flag

Conversation

@laurinehu

Copy link
Copy Markdown
Contributor

@laurinehu
laurinehu force-pushed the laurinehu/add_archived_flag branch from ae13288 to 17cf951 Compare July 7, 2025 14:40
@laurinehu laurinehu self-assigned this Jul 7, 2025
@laurinehu
laurinehu force-pushed the laurinehu/add_archived_flag branch from 17cf951 to d6bf357 Compare July 7, 2025 14:43
@laurinehu laurinehu added the ajouté Ajouté dans le changelog. label Jul 7, 2025
@laurinehu
laurinehu requested a review from rsebille July 7, 2025 15:09
@laurinehu

Copy link
Copy Markdown
Contributor Author

je me permets de t'identifier sur une PR avec des erreurs car je n'arrive pas à tester en local :))))) preneuse d'une session "refaire marche les emplois" à l'occasion, en attendant je suis déoslée :D

laurinehu and others added 2 commits July 17, 2025 06:09
@tonial
tonial force-pushed the laurinehu/add_archived_flag branch from d6bf357 to bc953aa Compare July 17, 2025 04:10
@tonial

tonial commented Jul 17, 2025 •

Copy link
Copy Markdown
Contributor

J'ai remplacé refused_by si None par refusal_reason == RefusalReason.AUTO

Les requêtes en plus dans les tests sont parce que, pour des raisons d'optimisation, on ne charge de la base de donnée que les champs utilisés : https://github.com/gip-inclusion/les-emplois/blob/master/itou/metabase/management/commands/populate_metabase_emplois.py#L345-L372

Donc sans rajouter refused_by ou refusal_reason dans la liste, on se retrouve à aller le chercher plus tard et ça rajoutait des requêtes.

@tonial
tonial enabled auto-merge July 17, 2025 04:13
@tonial
tonial added this pull request to the merge queue Jul 17, 2025
Merged via the queue into master with commit 30191c4 Jul 17, 2025
@tonial
tonial deleted the laurinehu/add_archived_flag branch July 17, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ajouté Ajouté dans le changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants