GEIQ: ajout de l'historique des actions sur la page de décision [GEN-2610] - #6578
Merged
Conversation
francoisfreitag
left a comment
francoisfreitag
left a comment
Member
There was a problem hiding this comment.
Une petite photo pour la PR ?
xavfernandez
force-pushed
the
xf/more_info_on_review
branch
2 times, most recently
from
July 22, 2025 08:37
fd951ef to
e593208
Compare
Contributor
Author
|
Photo ajoutée |
francoisfreitag
approved these changes
Jul 22, 2025
xavfernandez
force-pushed
the
xf/more_info_on_review
branch
from
July 22, 2025 13:57
e593208 to
5829e84
Compare
Contributor
Author
|
@francoisfreitag rajout de 3 commits pour avoir les départements (à beaucoup d'endroits) également. |
xavfernandez
force-pushed
the
xf/more_info_on_review
branch
2 times, most recently
from
July 23, 2025 19:10
e6743e8 to
06ffac7
Compare
xavfernandez
force-pushed
the
xf/more_info_on_review
branch
3 times, most recently
from
July 24, 2025 13:53
b7c0a50 to
febc474
Compare
francoisfreitag
approved these changes
Jul 24, 2025
| with_main_geiq=True, | ||
| label_antennas=[ | ||
| {"id": 123, "name": "Antenne de fourmi", "post_code": "12345"}, | ||
| {"id": 456, "name": "Antenne de télévision"}, |
Member
There was a problem hiding this comment.
Peut-être un commentaire ici pour dire que c’est en anticipation de mauvaises données dans Label ?
Contributor
Author
There was a problem hiding this comment.
Rajouté dans la méthode label_antenna_names 👍
xavfernandez
force-pushed
the
xf/more_info_on_review
branch
from
July 24, 2025 15:03
febc474 to
b49b19e
Compare
xavfernandez
enabled auto-merge
July 24, 2025 15:03
label_antennas shouldn't contain id=0 anymore. It used to mean that the assessment was also about the "main" GEIQ.
It is mandatory for DREETS accounting
xavfernandez
force-pushed
the
xf/more_info_on_review
branch
from
July 24, 2025 15:26
b49b19e to
6e5bc55
Compare
xavfernandez
added this pull request to the merge queue
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour que le document de décision soit recevable par le service comptable de la DREETS.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran
Avant:
Après: