Fiche de poste : Afficher le tableau des fiches de poste même s'il ne contient que la ligne des candidatures spontanées - #6619
Merged
Merged
Conversation
leo-naeka
reviewed
Jul 29, 2025
leo-naeka
left a comment
Contributor
There was a problem hiding this comment.
LGTM, mais j'en aurais bien profité pour s'assurer de la présence de la ligne dans TestJobDescriptionListView.test_response_content (ou bien une nouvelle TestJobDescriptionListView.test_response_content_with_no_job_descriptions)
Even if there is no job description, it is not empty because of the spontaneous application row.
Contributor
Author
|
Ça faisait effectivement vide. |
xavfernandez
approved these changes
Jul 29, 2025
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| {# Special row for controlling spontaneous applications #} |
Contributor
There was a problem hiding this comment.
Ça me fait me demander si cette ligne ne devrait pas être uniquement présente sur la page 1 ?
Contributor
Author
There was a problem hiding this comment.
Je m'en occupe dans une autre PR.
Mais avant je corrige/consolide les include "includes/pagination.html" (dans les tests, quand on a suffisamment d'éléments pour afficher la pagination, on a souvent des erreurs de variable non reconnue)
EwenKorr
added this pull request to the merge queue
Aug 1, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 1, 2025
EwenKorr
added this pull request to the merge queue
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Le tableau n'est jamais vide, il y a forcément au moins la ligne des candidatures spontanées.
Et cela rend plus logique la présence du bandeau dans le cas où il n'y a que l'entrée des candidatures spontanées, non mise à jour depuis au moins 2 mois (voir captures plus bas).
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran
Avant :
Après :