Éligibilité : Afficher la certification des critères administratifs aux prescripteurs habilités - #6661
Merged
Conversation
Member
Author
|
tonial
approved these changes
Aug 4, 2025
A hiring start date was required in order to compute whether the certification would be valid at a given date. Prescribers do not know the hiring start, so they would not know whether their diagnosis was backed by a state information system. Employer eligibility diagnosis were made to expire after 92 days (instead 183), so that the eligibility diagnosis expiry could be used instead of individual criteria certification period. Which means that we can simply check whether the criteria was certified and stop checking the certification_period entirely.
francoisfreitag
force-pushed
the
ff/crits
branch
from
August 7, 2025 11:39
df732bf to
5a73f23
Compare
A hiring start date was required in order to compute whether the certification would be valid at a given date. Prescribers do not know the hiring start, so they would not know whether their diagnosis was backed by a state information system. Employer eligibility diagnosis were made to expire after 92 days (instead 183), so that the eligibility diagnosis expiry could be used instead of individual criteria certification period. Which means that we can simply check whether the criteria was certified and stop checking the certification_period entirely.
Contributor
|
Je ne suis pas sure de bien tout comprendre. Je référence ici ma PR qui introduit de nouveaux badges. Avec les chassés croisés de congés de chacun, je pense que c'est inutile que je remette en place le système précédent. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Demande du métier. On a ajusté la durée de vie des diagnostics d’éligibilité pour ne plus avoir besoin de traiter la durée de certification de chaque critère.
https://gip-inclusion.slack.com/archives/C01181Y04LT/p1753367986581349
🍰 Comment ?
Retrait de
is_considered_certified, on lit directementcertifiedsur le critère administratif sélectionné. Cela simplifie l’architecture car on utilise directement les données de la base, au lieu de recalculer la validité de la certification pour chaque critère en fonction de la date d’embauche.🏝️ Comment tester ?
./manage.py shell:u = User.objects.get(last_name__iexact="Tibo") # Le candidat utilisé pour la candidatured = u.eligibility_diagnoses.get()s = d.selected_administrative_criteria.get()s.certified = Trues.save()💻 Captures d'écran