Repository navigation
Candidature: Amélioration de la délivrance automatique des PASS IAE - #6779
Merged
Merged
Conversation
tonial
force-pushed
the
alaurent/improve_job_app_accept
branch
from
September 2, 2025 14:25
d45fdab to
a2bf459
Compare
tonial
force-pushed
the
alaurent/clean_PE_approval
branch
from
September 2, 2025 14:25
f0c3600 to
214cfca
Compare
xavfernandez
reviewed
Sep 2, 2025
| self.job_seeker.jobseeker_profile.pole_emploi_id | ||
| elif ( # Try limiting duplicates | ||
| self.job_seeker.jobseeker_profile.nir | ||
| or self.job_seeker.approvals.exists() # expired and maybe still in waiting period |
Contributor
There was a problem hiding this comment.
Ta PR clarifie le code mais j'ai l'impression que cette ligne sur l'existence du PASS assouplit encore plus le mécanisme automatique.
Contributor
Author
There was a problem hiding this comment.
oui, en effet.
Mais pour moi, ce ne sont pas les cas de personne ayant déjà un PASS qui risquent de créer des doublons, si ?
A discuter ensemble avec le métier
Contributor
Author
There was a problem hiding this comment.
J'ai ajouté un 1er commit qui ne fait que ré-écrire la condition de manière plus lisible sans la modifier.
On verra pour la seconde partie
tonial
force-pushed
the
alaurent/improve_job_app_accept
branch
2 times, most recently
from
September 3, 2025 05:04
0499e10 to
dcc4612
Compare
tonial
force-pushed
the
alaurent/clean_PE_approval
branch
2 times, most recently
from
September 4, 2025 04:48
422b8d3 to
9ff7075
Compare
tonial
force-pushed
the
alaurent/improve_job_app_accept
branch
from
September 4, 2025 12:27
dcc4612 to
23231a8
Compare
Don't check old approvals to check if we won't to deliver an approval to a user with a NIR It's probably a mistake made in commit 588cd37, since the code does not match the commit message: JobApplication: automatically create a PASS if no PE Approval is found. If the user bears: - a NIR - or a pole emploi ID - or is not registered to PE AND we did not find any PASS or PE Approval that matches one of these IDs, then consider there is none and deliver the PASS automatically. In practice, there is actually none, usually, according to the support team.
tonial
force-pushed
the
alaurent/improve_job_app_accept
branch
from
September 4, 2025 13:09
23231a8 to
c092154
Compare
xavfernandez
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
https://www.notion.so/gip-inclusion/Am-liorer-la-proc-dure-de-d-livrance-des-PASS-2645f321b6048075a6f7fbb39c84e47d?v=18a5f321b604811bad80000cf7934cee&source=copy_link
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran