Candidature: envoi de la notification de transfert aux employeurs/orienteurs [GEN-2705] - #6798
Merged
Merged
Conversation
EwenKorr
approved these changes
Sep 5, 2025
EwenKorr
left a comment
EwenKorr
left a comment
Contributor
There was a problem hiding this comment.
À part le snapshot, ça m'a l'air ok !
Il n'y a pas quelque chose à optimiser d'ailleurs ? Je snapshot a changé avec une requête en plus, identique à plusieurs existant déjà. Ce n'est pas un signe de requête N+1 ?
xavfernandez
force-pushed
the
xf/transfer_notification_for_proxy
branch
2 times, most recently
from
September 5, 2025 07:55
42cbac4 to
0f53bd4
Compare
and update notification name to ease employer's understanding (and not mix it with JobApplicationTransferredForEmployerNotification)
xavfernandez
force-pushed
the
xf/transfer_notification_for_proxy
branch
from
September 5, 2025 08:03
0f53bd4 to
1ff403c
Compare
xavfernandez
added this pull request to the merge queue
Sep 5, 2025
Contributor
Author
|
Pour le snapshot, merci d'avoir soulevé le point: #6801 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Car ayant un rôle d'orienteur pour cette candidature, la notification peut les intéresser.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran