Repository navigation
GEIQ : Toujours permettre la modification du pays et de la commune de naissance du candidat à l’embauche - #6933
Merged
Merged
Conversation
xavfernandez
approved these changes
Oct 2, 2025
Member
Author
|
Je vous laisse jeter un œil au fixup, je mergerai en début de semaine prochaine. |
xavfernandez
approved these changes
Oct 2, 2025
francoisfreitag
force-pushed
the
ff/geiq-accept
branch
from
October 6, 2025 07:05
b61e33e to
e76369e
Compare
rsebille
approved these changes
Oct 6, 2025
Avoid conditionally showing this form. Employers should be able to update the birth_country and birth_place on hire (same as IAE employers). We might even want to drop this form to use the same code path as with IAE employers, but that’s another can of worms and the removal of these forms is scheduled (and in progress: https://www.notion.so/gip-inclusion/Refonte-parcours-embauche-1-3-tape-de-r-cup-ration-des-infos-du-candidat-1d55f321b6048046be8ec74bb62ff609).
francoisfreitag
force-pushed
the
ff/geiq-accept
branch
from
October 6, 2025 16:02
e76369e to
4f474c9
Compare
francoisfreitag
added this pull request to the merge queue
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Éviter de la logique conditionnelle, se rapprocher du parcours d’embauche IAE.
#6895 (comment)
On pourrait aussi imaginer utiliser les mêmes formulaires pour les données personnelles que dans l’IAE, mais ça représente plus de travail et ces formulaires sont en cours de refonte pour offrir un parcours unifié (#6732).