Repository navigation
API : Rendre l'API data⋅inclusion compatible avec le schéma V1 - #7039
Merged
Merged
Conversation
vperron
added
modifié
vperron
force-pushed
the
vperron/fix-di-api
branch
2 times, most recently
from
October 23, 2025 13:31
7ebcefc to
67bb038
Compare
vperron
marked this pull request as ready for review
October 23, 2025 13:32
vperron
force-pushed
the
vperron/fix-di-api
branch
from
October 23, 2025 14:39
67bb038 to
fecdcf8
Compare
10 tasks done
vperron
changed the title
vperron
force-pushed
the
vperron/fix-di-api
branch
from
October 24, 2025 11:15
fecdcf8 to
3e2ce17
Compare
xavfernandez
approved these changes
Oct 24, 2025
xavfernandez
left a comment
xavfernandez
left a comment
Contributor
There was a problem hiding this comment.
La N+1 de get_siret me chagrine toujours mais bon si on reste une récupération par jour on n'est pas à 500 requêtes près 🙈
Contributor
Author
|
En effet. On a un plan pour le faire côté DI plutôt (en publiant le SIRET non modifié dans l'API + l'ID de convention directement dans cette API) et ce serait même probablement le plan à terme mais comme on est ultra short sur le temps en ce moment et que ce code a le mérite:
Merci pour les relectures ! |
vperron
force-pushed
the
vperron/fix-di-api
branch
from
October 24, 2025 14:10
3e2ce17 to
79ca9d7
Compare
vperron
enabled auto-merge
October 24, 2025 14:10
vperron
added this pull request to the merge queue
Oct 24, 2025
leo-naeka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour Nexus on a besoin de MAJ les structures que DI reçoit des Emplois (et accessoiremen, pour la V1)
On va donc MAJ l'API historique que l'on utilise pour être au plus près de nos besoins; les deux endpoints seront utilisés, nous n'utiliserons pas l'API SIAE finalement.
🍰 Comment ?
Je retire les champs inutiles, clarifie ce qui peut l'être, etc.
🏝️ Comment tester ?
EN faisant une requête à l'API (authentification obligatoire, mais etre connecté à l'admin suffit)
Catégories changelog
API